Remove global variables

cmd/plugin_scaffold.go

@@ -5,16 +5,14 @@ import (
 	"github.com/spf13/cobra"
 )
 
-var (
-	pluginScaffoldInputFile string
-	pluginScaffoldOutputDir string
-)
-
 // pluginScaffoldCmd represents the scaffold command.
 var pluginScaffoldCmd = &cobra.Command{
 	Use:   "scaffold",
 	Short: "Scaffold a plugin and store the files into a directory",
 	Run: func(cmd *cobra.Command, _ []string) {
+		pluginScaffoldInputFile := cmd.Flag("input-file").Value.String()
+		pluginScaffoldOutputDir := cmd.Flag("output-dir").Value.String()
+
 		createdFiles, err := plugin.Scaffold(pluginScaffoldInputFile, pluginScaffoldOutputDir)
 		if err != nil {
 			cmd.Println("Scaffold failed: ", err)
@@ -31,12 +29,10 @@ var pluginScaffoldCmd = &cobra.Command{
 
 func init() {
 	pluginCmd.AddCommand(pluginScaffoldCmd)
-	pluginScaffoldCmd.Flags().StringVarP(
-		&pluginScaffoldInputFile,
+	pluginScaffoldCmd.Flags().StringP(
 		"input-file", "i", "input.yaml",
 		"Plugin scaffold input file")
-	pluginScaffoldCmd.Flags().StringVarP(
-		&pluginScaffoldOutputDir,
+	pluginScaffoldCmd.Flags().StringP(
 		"output-dir", "o", "./plugins",
 		"Output directory for the scaffold")
 }