Skip to content

Commit

Permalink
Remove compatibility policy
Browse files Browse the repository at this point in the history
  • Loading branch information
mostafa committed Dec 27, 2024
1 parent f8f24af commit 784cb3f
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 43 deletions.
21 changes: 9 additions & 12 deletions api/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,9 @@ func TestGetPlugins(t *testing.T) {
pluginRegistry := plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: zerolog.Logger{},
DevMode: true,
ActRegistry: actRegistry,
Logger: zerolog.Logger{},
DevMode: true,
},
)
pluginRegistry.Add(&plugin.Plugin{
Expand Down Expand Up @@ -192,10 +191,9 @@ func TestGetPluginsWithEmptyPluginRegistry(t *testing.T) {
pluginRegistry := plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: zerolog.Logger{},
DevMode: true,
ActRegistry: actRegistry,
Logger: zerolog.Logger{},
DevMode: true,
},
)

Expand Down Expand Up @@ -332,10 +330,9 @@ func TestGetServers(t *testing.T) {
pluginRegistry := plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: zerolog.Logger{},
DevMode: true,
ActRegistry: actRegistry,
Logger: zerolog.Logger{},
DevMode: true,
},
)

Expand Down
7 changes: 3 additions & 4 deletions api/healthcheck_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,9 @@ func Test_Healthchecker(t *testing.T) {
pluginRegistry := plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: zerolog.Logger{},
DevMode: true,
ActRegistry: actRegistry,
Logger: zerolog.Logger{},
DevMode: true,
},
)

Expand Down
30 changes: 12 additions & 18 deletions network/proxy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,8 @@ func TestNewProxy(t *testing.T) {
PluginRegistry: plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
},
),
HealthCheckPeriod: config.DefaultHealthCheckPeriod,
Expand Down Expand Up @@ -124,9 +123,8 @@ func BenchmarkNewProxy(b *testing.B) {
PluginRegistry: plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
},
),
HealthCheckPeriod: config.DefaultHealthCheckPeriod,
Expand Down Expand Up @@ -182,9 +180,8 @@ func BenchmarkProxyConnectDisconnect(b *testing.B) {
PluginRegistry: plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
},
),
HealthCheckPeriod: config.DefaultHealthCheckPeriod,
Expand Down Expand Up @@ -248,9 +245,8 @@ func BenchmarkProxyPassThrough(b *testing.B) {
PluginRegistry: plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
},
),
HealthCheckPeriod: config.DefaultHealthCheckPeriod,
Expand Down Expand Up @@ -319,9 +315,8 @@ func BenchmarkProxyIsHealthyAndIsExhausted(b *testing.B) {
PluginRegistry: plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
},
),
HealthCheckPeriod: config.DefaultHealthCheckPeriod,
Expand Down Expand Up @@ -388,9 +383,8 @@ func BenchmarkProxyAvailableAndBusyConnectionsString(b *testing.B) {
PluginRegistry: plugin.NewRegistry(
context.Background(),
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
},
),
HealthCheckPeriod: config.DefaultHealthCheckPeriod,
Expand Down
5 changes: 2 additions & 3 deletions network/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,8 @@ func TestRunServer(t *testing.T) {
pluginRegistry := plugin.NewRegistry(
ctx,
plugin.Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
})

pluginRegistry.AddHook(v1.HookName_HOOK_NAME_ON_TRAFFIC_FROM_CLIENT, 1, onIncomingTraffic)
Expand Down
10 changes: 4 additions & 6 deletions plugin/plugin_registry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ func NewPluginRegistry(t *testing.T) *Registry {
reg := NewRegistry(
context.Background(),
Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
})
return reg
}
Expand Down Expand Up @@ -157,9 +156,8 @@ func BenchmarkHookRun(b *testing.B) {
reg := NewRegistry(
context.Background(),
Registry{
ActRegistry: actRegistry,
Compatibility: config.Loose,
Logger: logger,
ActRegistry: actRegistry,
Logger: logger,
})
hookFunction := func(
_ context.Context, args *v1.Struct, _ ...grpc.CallOption,
Expand Down

0 comments on commit 784cb3f

Please sign in to comment.