test: Make plugin tests OS independent #459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests were not passing on MacOS because the expected plugin file name was hardcoded to include
linux-amd
, while plugin command will download the OS-specific file. This PR fixes this issue.Also, in
api_test.go
client can benil
(for example ifpsql
is not running), added arequire.NotNil
to fail gracefully instead of panicking.Development Checklist
Legal Checklist