Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Make plugin tests OS independent #459

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Hamsajj
Copy link
Contributor

@Hamsajj Hamsajj commented Feb 29, 2024

Description

The tests were not passing on MacOS because the expected plugin file name was hardcoded to include linux-amd, while plugin command will download the OS-specific file. This PR fixes this issue.

Also, in api_test.go client can be nil (for example if psql is not running), added a require.NotNil to fail gracefully instead of panicking.

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hamsajj,

Thanks a lot for your contribution! 🙏

@mostafa mostafa merged commit debb05c into gatewayd-io:main Feb 29, 2024
4 checks passed
smnmna99 pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants