Skip to content

Commit 0a1a8c2

Browse files
committedOct 18, 2024
deprecate globalstyles in favour of scoped style for component - closes rcpch#109
1 parent ac97ae8 commit 0a1a8c2

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed
 

‎src/RCPCHChart/RCPCHChart.tsx

+7-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// packages/libraries
22
import * as React from 'react';
33

4-
import { createGlobalStyle } from 'styled-components';
4+
import { styled } from 'styled-components';
55

66
// props and interfaces
77
import { RCPCHChartProps } from './RCPCHChart.types';
@@ -27,7 +27,7 @@ import { montserratItalic } from '../fonts/montserrat-italic-b64';
2727
// const VERSION_LOG = '[VI]Version: {version} - built on {date}[/VI]';
2828
const VERSION = '[VI]v{version}[/VI]'; // uses version injector plugin to Rollup to report package.json version
2929

30-
const GlobalStyle = createGlobalStyle`
30+
const GlobalStyle = styled.div`
3131
@font-face {
3232
font-family: 'Montserrat';
3333
src: url(${montserratRegular}) format('truetype'),
@@ -101,7 +101,7 @@ const RCPCHChart: React.FC<RCPCHChartProps> = ({
101101

102102

103103
// uncomment in development
104-
// console.log("loading from locally...");
104+
console.log("loading from locally...");
105105

106106
// create subtitle from sex, reference and measurementMethod
107107
const subtitleReferenceMeasurementMethod = `${nameForReference(reference)} - ${nameForMeasurementMethod(measurementMethod)}`
@@ -118,7 +118,7 @@ const RCPCHChart: React.FC<RCPCHChartProps> = ({
118118

119119
return (
120120
<ErrorBoundary styles={styles}>
121-
<GlobalStyle />
121+
<GlobalStyle>
122122
<CentileChart
123123
chartsVersion={VERSION}
124124
reference={reference}
@@ -134,6 +134,7 @@ const RCPCHChart: React.FC<RCPCHChartProps> = ({
134134
exportChartCallback={exportChartCallback}
135135
clinicianFocus={clinicianFocus}
136136
/>
137+
</GlobalStyle>
137138
</ErrorBoundary>
138139
);
139140
} else {
@@ -150,7 +151,7 @@ const RCPCHChart: React.FC<RCPCHChartProps> = ({
150151

151152
return (
152153
<ErrorBoundary styles={styles}>
153-
<GlobalStyle />
154+
<GlobalStyle>
154155
<SDSChart
155156
chartsVersion={VERSION}
156157
reference={reference}
@@ -166,6 +167,7 @@ const RCPCHChart: React.FC<RCPCHChartProps> = ({
166167
exportChartCallback={exportChartCallback}
167168
clinicianFocus={clinicianFocus}
168169
/>
170+
</GlobalStyle>
169171
</ErrorBoundary>
170172
);
171173
}

0 commit comments

Comments
 (0)