add flag to disable logging #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did submit a PR to Telescope |
|
Is this not necessary now? |
|
No, not necessary as long as #78 is merged. Maybe still useful for finer-grained control over logging 🤷🏻♂️ |
|
Is that a feature of regular eloquent queries? Is there a control for that somewhere which isn't being respected here? I wouldn't want to add stuff like that without some explicit need to match functionality. |
|
Not that I know of. Makes sense 🙂 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m using a mysql database for my app, as well as this package to access a FileMaker database for some additional data.
I’m also using Laravel Telescope, which listens to the
\Illuminate\Database\Events\QueryExecutedevent.However, that results in
ERROR Call to a member function quote() on string in vendor/laravel/telescope/src/Watchers/QueryWatcher.php on line 122.in Telescope because this line is trying to get aPDOinstance.This PR adds the ability to disable query logging just for FM queries, while leaving it on for mysql queries. The alternative would be to totally disable query logging in Telescope.