IdProviderFactory.php

- new method naming
- instead of isUniqueId use name getUniqueIdChecker to reflect the functionality better

Author: gesinn-it-ilm

src/IdProvider.php

@@ -29,15 +29,15 @@ class IdProvider {
 	 * @var callable Function to decide if string ID already exists, i.e. is already used as a
 	 * WikiPage
 	 */
-	private $isUniqueId;
+	private $getUniqueIdChecker;
 
 	/**
 	 * @param $generator
-	 * @param null $isUniqueId
+	 * @param null $getUniqueIdChecker
 	 */
-	public function __construct( $generator, $isUniqueId = null ) {
+	public function __construct( $generator, $getUniqueIdChecker = null ) {
 		$this->generator = $generator;
-		$this->isUniqueId = $isUniqueId;
+		$this->getUniqueIdChecker = $getUniqueIdChecker;
 	}
 
 	public function getId( array $params = [] ): string {
@@ -47,7 +47,7 @@ public function getId( array $params = [] ): string {
 		$prefix = trim( $prefix );
 		$id = $prefix . $this->generator->generate();
 		if ( !$skipUniqueTest ) {
-			while ( !( $this->isUniqueId )( $id ) ) {
+			while ( !( $this->getUniqueIdChecker )( $id ) ) {
 				$id = $prefix . $this->generator->generate();
 			}
 		}

src/IdProviderFactory.php

@@ -39,7 +39,7 @@ public static function random( array $params = [] ) {
 	}
 
 	private static function provider( $generator ) {
-		return new IdProvider( $generator, self::isUniqueId() );
+		return new IdProvider( $generator, self::getUniqueIdChecker() );
 	}
 
 	private static function dbExecute() {
@@ -65,7 +65,7 @@ private static function dbExecute() {
 	 * @param string $text The title or ID to check for uniqueness of the wiki page.
 	 * @return \Closure
 	 */
-	private static function isUniqueId() {
+	private static function getUniqueIdChecker() {
 		return function ( $text ) {
 			$title = Title::newFromText( $text );
 

tests/phpunit/Unit/IdProviderFactoryTest.php

@@ -51,9 +51,9 @@ public function testIncrementCreatesIncrementIdGenerator() {
 		$this->assertEquals( IncrementIdGenerator::class, $provider->generatorClass() );
 	}
 
-	public function testIsUniqueId() {	
+	public function testGetUniqueIdChecker() {	
 		// Call the private method using Reflection
-		$reflection = new \ReflectionMethod( IdProviderFactory::class, 'isUniqueId' );
+		$reflection = new \ReflectionMethod( IdProviderFactory::class, 'getUniqueIdChecker' );
 		$reflection->setAccessible( true );
 		$isUniqueClosure = $reflection->invoke( null );