Issue 19 - call to undefined method WikiPage::factory() #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update isUniqueId() - increase test coverage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
============================================
+ Coverage 44.75% 46.99% +2.24%
- Complexity 47 48 +1
============================================
Files 8 8
Lines 181 183 +2
============================================
+ Hits 81 86 +5
+ Misses 100 97 -3 ☔ View full report in Codecov by Sentry. |
- update isUniqueId() - update tests
|
@gesinn-it-gea could you please review this and if this is ok, we can merge this one as well. |
- new method naming - instead of isUniqueId use name getUniqueIdChecker to reflect the functionality better
- update PHPDoc
- add new test cases to check whenever the page exists or not
- update function param, add $id instead of $text
|
@gesinn-it-gea PR updated and ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #19.
This PR contains:
isUniqueId()updated, renamed togetUniqueIdChecker()IdProviderFactory.php, covergetUniqueIdChecker()function