fixed broken use of Job Queue

Author: gesinn-it-gea

Diff for: SemanticDependencyUpdater.hooks.php

@@ -148,10 +148,16 @@ public static function dummyEdit( $title ) {
 			$page = WikiPage::newFromID( $title->getArticleId() );
 			if ( $page ) { // prevent NPE when page not found
 				$content = $page->getContent( Revision::RAW );
-				$text = ContentHandler::getContentText( $content );
-				$page->doEditContent( ContentHandler::makeContent( $text, $page->getTitle() ),
-					"[SemanticDependencyUpdater] Null edit." ); // since this is a null edit, the edit summary will be ignored.
-				$page->doPurge(); // required since SMW 2.5.1
+
+				if ( $content ) {
+					$text = ContentHandler::getContentText( $content );
+					$page->doEditContent( ContentHandler::makeContent( $text, $page->getTitle() ),
+						"[SemanticDependencyUpdater] Null edit." ); // since this is a null edit, the edit summary will be ignored.
+					$page->doPurge(); // required since SMW 2.5.1
+					
+					# Consider calling doSecondaryDataUpdates() for MW 1.32+
+					# https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html#ac761e927ec2e7d95c9bb48aac60ff7c8
+				}
 			}
 		}
 	}

Diff for: extension.json

@@ -27,7 +27,7 @@
     ]
   },
   "JobClasses": {
-    "SDU\\DummyEditJob": "DummyEditJob"
+    "DummyEditJob": "SDU\\DummyEditJob"
   },
   "callback": "SDU\\Hooks::setup",
   "config": {

Diff for: includes/DummyEditJob.php

@@ -18,24 +18,22 @@ function __construct( $title, $params = '', $id = 0 ) {
 	 * @return boolean success
 	 */
 	function run() {
-		wfProfileIn( __METHOD__ );
-
-		if ( is_null( $this->title ) ) {
-			$this->error = "DummyEditJob: Invalid title";
-			wfProfileOut( __METHOD__ );
-			return false;
-		}
-
 		$page = WikiPage::newFromID( $this->title->getArticleId() );
 		if ( $page ) { // prevent NPE when page not found
 			$content = $page->getContent( Revision::RAW );
-			$text = ContentHandler::getContentText( $content );
-			$page->doEditContent( ContentHandler::makeContent( $text, $page->getTitle() ),
-				"[SemanticDependencyUpdater] Null edit." ); // since this is a null edit, the edit summary will be ignored.
-			$page->doPurge(); // required since SMW 2.5.1
+
+			if ( $content ) {
+				$text = ContentHandler::getContentText( $content );
+				$page->doEditContent( ContentHandler::makeContent( $text, $page->getTitle() ),
+					"[SemanticDependencyUpdater] Null edit." ); // since this is a null edit, the edit summary will be ignored.
+				$page->doPurge(); // required since SMW 2.5.1
+
+				# Consider calling doSecondaryDataUpdates() for MW 1.32+
+				# https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html#ac761e927ec2e7d95c9bb48aac60ff7c8
+			}
+
 		}
 
-		wfProfileOut( __METHOD__ );
 		return true;
 	}
 }