Skip to content

Commit f5436c3

Browse files
gesinn-it-evlgesinn-it-evl
committed
phpcs fixes
1 parent b4426d7 commit f5436c3

File tree

1 file changed

+52
-75
lines changed

1 file changed

+52
-75
lines changed

Diff for: ‎src/Hooks.php

+52-75
Original file line numberDiff line numberDiff line change
@@ -4,78 +4,72 @@
44

55
use DeferredUpdates;
66
use JobQueueGroup;
7-
use SMW\Options;
8-
use SMW\Services\ServicesFactory as ApplicationFactory;
97
use SMW\MediaWiki\Jobs\UpdateJob;
8+
use SMW\Services\ServicesFactory as ApplicationFactory;
109
use SMWDIBlob;
1110
use SMWQueryProcessor;
1211
use SMWSemanticData;
1312
use SMWStore;
14-
use WikiPage;
1513

16-
class Hooks
17-
{
14+
class Hooks {
1815

19-
public static function setup()
20-
{
21-
if (!defined('MEDIAWIKI')) {
16+
public static function setup() {
17+
if ( !defined( 'MEDIAWIKI' ) ) {
2218
die();
2319
}
2420

25-
if (!defined('SMW_VERSION')) {
26-
die("ERROR: Semantic MediaWiki must be installed for Semantic Dependency Updater to run!");
21+
if ( !defined( 'SMW_VERSION' ) ) {
22+
die( "ERROR: Semantic MediaWiki must be installed for Semantic Dependency Updater to run!" );
2723
}
2824
}
2925

3026
public static function onAfterDataUpdateComplete(
3127
SMWStore $store, SMWSemanticData $newData,
3228
$compositePropertyTableDiffIterator
33-
)
34-
{
29+
) {
3530
global $wgSDUProperty;
3631
global $wgSDUTraversed;
3732

38-
if (!isset($wgSDUTraversed)) {
33+
if ( !isset( $wgSDUTraversed ) ) {
3934
$wgSDUTraversed = [];
4035
}
4136

42-
$wgSDUProperty = str_replace(' ', '_', $wgSDUProperty);
37+
$wgSDUProperty = str_replace( ' ', '_', $wgSDUProperty );
4338
$subject = $newData->getSubject();
4439
$title = $subject->getTitle();
45-
if ($title == null) {
40+
if ( $title == null ) {
4641
return true;
4742
}
4843

4944
$id = $title->getPrefixedDBKey();
5045

51-
wfDebugLog('SemanticDependencyUpdater', "[SDU] --> " . $title);
46+
wfDebugLog( 'SemanticDependencyUpdater', "[SDU] --> " . $title );
5247

5348
// FIRST CHECK: Does the page data contain a $wgSDUProperty semantic property ?
5449
$properties = $newData->getProperties();
55-
if (!isset($properties[$wgSDUProperty])) {
56-
wfDebugLog('SemanticDependencyUpdater', "[SDU] <-- No SDU property found");
50+
if ( !isset( $properties[$wgSDUProperty] ) ) {
51+
wfDebugLog( 'SemanticDependencyUpdater', "[SDU] <-- No SDU property found" );
5752
return true;
5853
}
5954

6055
$diffTable = $compositePropertyTableDiffIterator->getOrderedDiffByTable();
6156
$smwSID = $compositePropertyTableDiffIterator->getSubject()->getId();
6257
// SECOND CHECK: Have there been actual changes in the data? (Ignore internal SMW data!)
6358
// TODO: Introduce an explicit list of Semantic Properties to watch ?
64-
unset($diffTable['smw_fpt_mdat']); // Ignore SMW's internal properties "smw_fpt_mdat"
59+
unset( $diffTable['smw_fpt_mdat'] ); // Ignore SMW's internal properties "smw_fpt_mdat"
6560

6661
// lets try first to check the data tables: https://www.semantic-mediawiki.org/wiki/Help:Database_schema
6762
// if change, on pageID from Issue, that is not REvision ID, then trigger all changes
6863
$triggerSemanticDependencies = false;
6964

65+
if ( count( $diffTable ) > 0 ) {
66+
wfDebugLog( 'SemanticDependencyUpdater', "[SDU] -----> Data changes detected" );
7067

71-
if (count($diffTable) > 0) {
72-
wfDebugLog('SemanticDependencyUpdater', "[SDU] -----> Data changes detected");
73-
74-
foreach ($diffTable as $key => $value) {
75-
if (strpos($key, 'smw_di') === 0 && is_array($value)) {
76-
foreach ($value["insert"] as $insert) {
77-
if ($insert["s_id"] == $smwSID) {
78-
if ($insert["p_id"] != 506) {
68+
foreach ( $diffTable as $key => $value ) {
69+
if ( strpos( $key, 'smw_di' ) === 0 && is_array( $value ) ) {
70+
foreach ( $value["insert"] as $insert ) {
71+
if ( $insert["s_id"] == $smwSID ) {
72+
if ( $insert["p_id"] != 506 ) {
7973
$triggerSemanticDependencies = true;
8074
break 2;
8175
} // revision ID change is good, but must not trigger UpdateJob for semantic dependencies
@@ -85,20 +79,20 @@ public static function onAfterDataUpdateComplete(
8579
}
8680
}
8781
} else {
88-
wfDebugLog('SemanticDependencyUpdater', "[SDU] <-- No semantic data changes detected");
82+
wfDebugLog( 'SemanticDependencyUpdater', "[SDU] <-- No semantic data changes detected" );
8983
return true;
9084
}
9185

9286
// THIRD CHECK: Has this page been already traversed more than twice?
9387
// This should only be the case when SMW errors occur.
9488
// In that case, the diffTable contains everything and SDU can't know if changes happened
95-
if (array_key_exists($id, $wgSDUTraversed)) {
89+
if ( array_key_exists( $id, $wgSDUTraversed ) ) {
9690
$wgSDUTraversed[$id] = $wgSDUTraversed[$id] + 1;
9791
} else {
9892
$wgSDUTraversed[$id] = 1;
9993
}
100-
if ($wgSDUTraversed[$id] > 2) {
101-
wfDebugLog('SemanticDependencyUpdater', "[SDU] <-- Already traversed");
94+
if ( $wgSDUTraversed[$id] > 2 ) {
95+
wfDebugLog( 'SemanticDependencyUpdater', "[SDU] <-- Already traversed" );
10296
return true;
10397
}
10498

@@ -107,86 +101,70 @@ public static function onAfterDataUpdateComplete(
107101
// SMW\SemanticData $newData
108102
// SMWDataItem[] $dataItem
109103
$wikiPageValues = [];
110-
if ($triggerSemanticDependencies) {
111-
$dataItem = $newData->getPropertyValues($properties[$wgSDUProperty]);
112-
if ($dataItem != null) {
113-
foreach ($dataItem as $valueItem) {
114-
if ($valueItem instanceof SMWDIBlob && $valueItem->getString() != $id) {
115-
$wikiPageValues = array_merge($wikiPageValues, self::updatePagesMatchingQuery($valueItem->getSerialization()));
104+
if ( $triggerSemanticDependencies ) {
105+
$dataItem = $newData->getPropertyValues( $properties[$wgSDUProperty] );
106+
if ( $dataItem != null ) {
107+
foreach ( $dataItem as $valueItem ) {
108+
if ( $valueItem instanceof SMWDIBlob && $valueItem->getString() != $id ) {
109+
$wikiPageValues = array_merge( $wikiPageValues, self::updatePagesMatchingQuery( $valueItem->getSerialization() ) );
116110
}
117111
}
118112
}
119113
} else {
120-
$wikiPageValues = [$subject];
114+
$wikiPageValues = [ $subject ];
121115
}
122116

123-
124-
self::rebuildData($triggerSemanticDependencies, $wikiPageValues, $subject);
117+
self::rebuildData( $triggerSemanticDependencies, $wikiPageValues, $subject );
125118

126119
return true;
127120
}
128121

129122
/**
130123
* @param string $queryString Query string, excluding [[ and ]] brackets
131124
*/
132-
private static function updatePagesMatchingQuery($queryString)
133-
{
125+
private static function updatePagesMatchingQuery( $queryString ) {
134126
global $sfgListSeparator;
135127

136-
$queryString = str_replace('AND', ']] [[', $queryString);
137-
$queryString = str_replace('OR', ']] OR [[', $queryString);
128+
$queryString = str_replace( 'AND', ']] [[', $queryString );
129+
$queryString = str_replace( 'OR', ']] OR [[', $queryString );
138130

139131
// If SF is installed, get the separator character and change it into ||
140132
// Otherwise SDU won't work with multi-value properties
141-
if (isset($sfgListSeparator)) {
142-
$queryString = rtrim($queryString, $sfgListSeparator);
143-
$queryString = str_replace($sfgListSeparator, ' || ', $queryString);
133+
if ( isset( $sfgListSeparator ) ) {
134+
$queryString = rtrim( $queryString, $sfgListSeparator );
135+
$queryString = str_replace( $sfgListSeparator, ' || ', $queryString );
144136
}
145137

146-
wfDebugLog('SemanticDependencyUpdater', "[SDU] --------> [[$queryString]]");
138+
wfDebugLog( 'SemanticDependencyUpdater', "[SDU] --------> [[$queryString]]" );
147139

148140
$store = smwfGetStore();
149141

150142
$params = [
151143
'limit' => 10000,
152144
];
153-
$processedParams = SMWQueryProcessor::getProcessedParams($params);
145+
$processedParams = SMWQueryProcessor::getProcessedParams( $params );
154146
$query =
155-
SMWQueryProcessor::createQuery("[[$queryString]]", $processedParams, SMWQueryProcessor::SPECIAL_PAGE);
156-
$result = $store->getQueryResult($query); // SMWQueryResult
157-
$wikiPageValues = $result->getResults(); // array of SMWWikiPageValues
147+
SMWQueryProcessor::createQuery( "[[$queryString]]", $processedParams, SMWQueryProcessor::SPECIAL_PAGE );
148+
$result = $store->getQueryResult( $query );
149+
$wikiPageValues = $result->getResults();
158150

159151
return $wikiPageValues;
160152
}
161153

162154
/**
163155
* Rebuilds data of the given wikipages to regenerate semantic attrubutes and re-run queries
164-
*
165-
* @param SMWWikiPageValues[] $wikiPageValues
166-
* @param SMWStore $store
167156
*/
168-
public static function rebuildData($triggerSemanticDependencies, $wikiPageValues, $subject)
169-
{
157+
public static function rebuildData( $triggerSemanticDependencies, $wikiPageValues, $subject ) {
170158
global $wgSDUUseJobQueue;
171159

172-
if ($wgSDUUseJobQueue) {
160+
if ( $wgSDUUseJobQueue ) {
173161
$jobFactory = ApplicationFactory::getInstance()->newJobFactory();
174162

175-
if ($triggerSemanticDependencies) {
176-
// DeferredUpdates::addCallableUpdate(static function () use ($jobFactory, $subject) {
177-
// $job = $jobFactory->newUpdateJob(
178-
// $subject->getTitle(),
179-
// [
180-
// UpdateJob::FORCED_UPDATE => true,
181-
// 'shallowUpdate' => false
182-
// ]
183-
// );
184-
// $job->run();
185-
// });
163+
if ( $triggerSemanticDependencies ) {
186164

187165
$jobs = [];
188166

189-
foreach ($wikiPageValues as $wikiPageValue) {
167+
foreach ( $wikiPageValues as $wikiPageValue ) {
190168
$jobs[] = $jobFactory->newUpdateJob(
191169
$wikiPageValue->getTitle(),
192170
[
@@ -195,11 +173,11 @@ public static function rebuildData($triggerSemanticDependencies, $wikiPageValues
195173
]
196174
);
197175
}
198-
if ($jobs) {
199-
JobQueueGroup::singleton()->lazyPush($jobs);
176+
if ( $jobs ) {
177+
JobQueueGroup::singleton()->lazyPush( $jobs );
200178
}
201179
} else {
202-
DeferredUpdates::addCallableUpdate(static function () use ($jobFactory, $wikiPageValues) {
180+
DeferredUpdates::addCallableUpdate( static function () use ( $jobFactory, $wikiPageValues ) {
203181
$job = $jobFactory->newUpdateJob(
204182
$wikiPageValues[0]->getTitle(),
205183
[
@@ -208,11 +186,10 @@ public static function rebuildData($triggerSemanticDependencies, $wikiPageValues
208186
]
209187
);
210188
$job->run();
211-
});
189+
} );
212190
}
213191

214192
}
215-
216193
}
217194

218195
}

0 commit comments

Comments
 (0)