Skip to content

Use of wfGetDB was deprecated in MediaWiki 1.39 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
krabina opened this issue Feb 7, 2025 · 4 comments
Open

Use of wfGetDB was deprecated in MediaWiki 1.39 #89

krabina opened this issue Feb 7, 2025 · 4 comments
Labels
MW 1.43

Comments

@krabina
Copy link

krabina commented Feb 7, 2025

Trying to use PF on MW 1.43 result in:

Deprecated: Use of wfGetDB was deprecated in MediaWiki 1.39. [Called from PFFormLinker::getDefaultForm in * extensions/PageForms/includes/PF_FormLinker.php at line 30] in * includes/debug/MWDebug.php on line 385
MediaWiki internal error.

Original exception: [e586a5cb7891bed10a1aea4b] /Hauptseite TypeError: PFHooks::registerModules(): Argument #1 ($resourceLoader) must be of type ResourceLoader, MediaWiki\ResourceLoader\ResourceLoader given, called in * includes/HookContainer/HookContainer.php on line 159
Backtrace:
from * extensions/PageForms/includes/PF_Hooks.php(85)
#0 * includes/HookContainer/HookContainer.php(159): PFHooks::registerModules()
#1 * includes/ResourceLoader/HookRunner.php(55): MediaWiki\HookContainer\HookContainer->run()
#2 * includes/ServiceWiring.php(1910): MediaWiki\ResourceLoader\HookRunner->onResourceLoaderRegisterModules()
#3 * vendor/wikimedia/services/src/ServiceContainer.php(440): Wikimedia\Services\ServiceContainer::{closure}()
#4 * vendor/wikimedia/services/src/ServiceContainer.php(406): Wikimedia\Services\ServiceContainer->createService()
#5 * includes/MediaWikiServices.php(356): Wikimedia\Services\ServiceContainer->getService()
#6 * includes/MediaWikiServices.php(1740): MediaWiki\MediaWikiServices->getService()
#7 * includes/Output/OutputPage.php(3881): MediaWiki\MediaWikiServices->getResourceLoader()
#8 * includes/Output/OutputPage.php(3655): MediaWiki\Output\OutputPage->getResourceLoader()
#9 * includes/Output/OutputPage.php(3698): MediaWiki\Output\OutputPage->getRlClientContext()
#10 * includes/Output/OutputPage.php(3799): MediaWiki\Output\OutputPage->getRlClient()
#11 * includes/skins/Skin.php(693): MediaWiki\Output\OutputPage->headElement()
#12 * includes/Output/OutputPage.php(3193): Skin->outputPageFinal()
#13 * includes/actions/ActionEntryPoint.php(163): MediaWiki\Output\OutputPage->output()
#14 * includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#15 * index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#16 {main}

Exception caught inside exception handler: [e586a5cb7891bed10a1aea4b] /Hauptseite TypeError: PFHooks::registerModules(): Argument #1 ($resourceLoader) must be of type ResourceLoader, MediaWiki\ResourceLoader\ResourceLoader given, called in * includes/HookContainer/HookContainer.php on line 159
Backtrace:
from * extensions/PageForms/includes/PF_Hooks.php(85)
#0 * includes/HookContainer/HookContainer.php(159): PFHooks::registerModules()
#1 * includes/ResourceLoader/HookRunner.php(55): MediaWiki\HookContainer\HookContainer->run()
#2 * includes/ServiceWiring.php(1910): MediaWiki\ResourceLoader\HookRunner->onResourceLoaderRegisterModules()
#3 * vendor/wikimedia/services/src/ServiceContainer.php(440): Wikimedia\Services\ServiceContainer::{closure}()
#4 * vendor/wikimedia/services/src/ServiceContainer.php(406): Wikimedia\Services\ServiceContainer->createService()
#5 * includes/MediaWikiServices.php(356): Wikimedia\Services\ServiceContainer->getService()
#6 * includes/MediaWikiServices.php(1740): MediaWiki\MediaWikiServices->getService()
#7 * includes/Output/OutputPage.php(3881): MediaWiki\MediaWikiServices->getResourceLoader()
#8 * includes/Output/OutputPage.php(3655): MediaWiki\Output\OutputPage->getResourceLoader()
#9 * includes/Output/OutputPage.php(3698): MediaWiki\Output\OutputPage->getRlClientContext()
#10 * includes/Output/OutputPage.php(3799): MediaWiki\Output\OutputPage->getRlClient()
#11 * includes/skins/Skin.php(693): MediaWiki\Output\OutputPage->headElement()
#12 * includes/Output/OutputPage.php(3193): Skin->outputPageFinal()
#13 * includes/exception/MWExceptionRenderer.php(190): MediaWiki\Output\OutputPage->output()
#14 * includes/exception/MWExceptionRenderer.php(109): MWExceptionRenderer::reportHTML()
#15 * includes/exception/MWExceptionHandler.php(135): MWExceptionRenderer::output()
#16 * includes/exception/MWExceptionHandler.php(239): MWExceptionHandler::report()
#17 * includes/MediaWikiEntryPoint.php(222): MWExceptionHandler::handleException()
#18 * includes/actions/ActionEntryPoint.php(82): MediaWiki\MediaWikiEntryPoint->handleTopLevelError()
#19 * includes/MediaWikiEntryPoint.php(206): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError()
#20 * index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#21 {main}
@alex4401
Copy link

Removing the type hint works the exception around but is probably not that ideal. MW 1.42 dropped the \ResourceLoader alias.

Additionally, Special:MultiPageEdit crashes if there are no candidates - I believe the handling was more graceful in 1.41:

[ccee9e6e2a4b3194d088fbdc] /wiki/Special:MultiPageEdit InvalidArgumentException: Wikimedia\Rdbms\Platform\SQLPlatform::makeList: empty input for field page_title

Backtrace:

from /srv/mw/1.43/includes/libs/rdbms/platform/SQLPlatform.php(257)
#0 /srv/mw/1.43/includes/libs/rdbms/platform/SQLPlatform.php(724): Wikimedia\Rdbms\Platform\SQLPlatform->makeList()
#1 /srv/mw/1.43/includes/libs/rdbms/database/Database.php(3305): Wikimedia\Rdbms\Platform\SQLPlatform->selectSQLText()
#2 /srv/mw/1.43/includes/libs/rdbms/database/DatabaseMySQL.php(644): Wikimedia\Rdbms\Database->selectSQLText()
#3 /srv/mw/1.43/includes/libs/rdbms/database/Database.php(1337): Wikimedia\Rdbms\DatabaseMySQL->selectSQLText()
#4 /srv/mw/1.43/includes/libs/rdbms/database/DBConnRef.php(127): Wikimedia\Rdbms\Database->select()
#5 /srv/mw/1.43/includes/libs/rdbms/database/DBConnRef.php(351): Wikimedia\Rdbms\DBConnRef->__call()
#6 /srv/mw/1.43/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php(745): Wikimedia\Rdbms\DBConnRef->select()
#7 /srv/mw/1.43/includes/specialpage/QueryPage.php(570): Wikimedia\Rdbms\SelectQueryBuilder->fetchResultSet()
#8 /srv/mw/1.43/includes/specialpage/QueryPage.php(734): MediaWiki\SpecialPage\QueryPage->reallyDoQuery()
#9 /srv/mw/1.43/extensions/PageForms/specials/PF_MultiPageEdit.php(58): MediaWiki\SpecialPage\QueryPage->execute()
#10 /srv/mw/1.43/includes/specialpage/SpecialPage.php(731): PFMultiPageEdit->execute()
#11 /srv/mw/1.43/includes/specialpage/SpecialPageFactory.php(1724): MediaWiki\SpecialPage\SpecialPage->run()
#12 /srv/mw/1.43/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#13 /srv/mw/1.43/includes/actions/ActionEntryPoint.php(146): MediaWiki\Actions\ActionEntryPoint->performRequest()
#14 /srv/mw/1.43/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#15 /srv/mw/1.43/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#16 /srv/mw/bootstrap/index.php(3): require(string)
#17 {main}

@alex4401
Copy link

alex4401 commented Feb 24, 2025 •
edited
Loading

At Special:RunQuery:

[aff4208d7e1ca24517694976] /wiki/Special:RunQuery/Card Error: Call to undefined method MediaWiki\Parser\Parser::getFreshParser()

Backtrace:

from /srv/mw/1.43/extensions/PageForms/includes/PF_FormPrinter.php(961)
#0 [internal function]: PFFormPrinter->formHTML()
#1 /srv/mw/1.43/includes/StubObject/StubObject.php(125): call_user_func_array()
#2 /srv/mw/1.43/includes/StubObject/StubObject.php(155): MediaWiki\StubObject\StubObject->_call()
#3 /srv/mw/1.43/extensions/PageForms/specials/PF_RunQuery.php(89): MediaWiki\StubObject\StubObject->__call()
#4 /srv/mw/1.43/extensions/PageForms/specials/PF_RunQuery.php(28): PFRunQuery->printPage()
#5 /srv/mw/1.43/includes/specialpage/SpecialPage.php(731): PFRunQuery->execute()
#6 /srv/mw/1.43/includes/specialpage/SpecialPageFactory.php(1724): MediaWiki\SpecialPage\SpecialPage->run()
#7 /srv/mw/1.43/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#8 /srv/mw/1.43/includes/actions/ActionEntryPoint.php(146): MediaWiki\Actions\ActionEntryPoint->performRequest()
#9 /srv/mw/1.43/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#10 /srv/mw/1.43/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#11 /srv/mw/bootstrap/index.php(3): require(string)
#12 {main}

formedit action:

[adb8b0619bbfdf8f5581e149] /wiki/Therazane?action=formedit Error: Call to a member function getTitle() on null

Backtrace:

from /srv/mw/1.43/extensions/PageForms/includes/PF_FormEditAction.php(288)
#0 /srv/mw/1.43/extensions/PageForms/includes/PF_FormEditAction.php(32): PFFormEditAction::displayForm()
#1 /srv/mw/1.43/includes/actions/ActionEntryPoint.php(736): PFFormEditAction->show()
#2 /srv/mw/1.43/includes/actions/ActionEntryPoint.php(510): MediaWiki\Actions\ActionEntryPoint->performAction()
#3 /srv/mw/1.43/includes/actions/ActionEntryPoint.php(146): MediaWiki\Actions\ActionEntryPoint->performRequest()
#4 /srv/mw/1.43/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#5 /srv/mw/1.43/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#6 /srv/mw/bootstrap/index.php(3): require(string)
#7 {main}

@gesinn-it-gea
Copy link

sounds like unrelated issues

@gesinn-it-gea gesinn-it-gea changed the title Error in MW 1.43 Use of wfGetDB was deprecated in MediaWiki 1.39 Feb 25, 2025
@gesinn-it-gea
Copy link

Include upstream fix wikimedia@d0f4411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MW 1.43
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krabina @gesinn-it-gea @alex4401