From 9bfbb4c8a1b722eac8dd1f1b1b71b1fcbf1f02ce Mon Sep 17 00:00:00 2001 From: MarekMaj Date: Fri, 7 Jun 2024 21:48:06 +0200 Subject: [PATCH] Reinstatiate javadoc step in common build (#102) * Reinstatiate javadoc step in common build * Fix
tag for javadoc --- .github/workflows/build.yml | 2 +- .../http/HttpPostRequestCallbackFactory.java | 21 ++++++++++--------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ee58d8e0..b19041f5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -38,7 +38,7 @@ jobs: - name: Test JavaDoc run: mvn $MAVEN_CLI_OPTS $JAVA_ADDITIONAL_OPTS javadoc:javadoc - if: startsWith(matrix.flink, '1.15.0') + if: startsWith(matrix.flink, '1.18') - name: Add coverage to PR id: jacoco diff --git a/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java b/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java index c4b3e5a0..7e722c20 100644 --- a/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java +++ b/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java @@ -13,16 +13,17 @@ * other factories in *
resources/META-INF/services/org.apache.flink.table.factories.Factory
* file and then referenced by their identifiers in: - *
  • - * The HttpSink DDL property field gid.connector.http.sink.request-callback - * for HTTP sink. - *
  • - *
  • - * The Http lookup DDL property field gid.connector.http.source.lookup.request-callback - * for HTTP lookup. - *
  • - * - *
    + * + *
    * *

    The following example shows the minimum Table API example to create a {@link HttpDynamicSink} * that uses a custom callback created by a factory that returns my-callback as its