Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Grzegorz Kołakowski committed Oct 17, 2024
1 parent 2d1ffe9 commit c277429
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class ElasticSearchLiteQueryCreatorTest {


@Test
public void testWithEmptyLookup() {
public void testWithEmptyLookupResult() {

// GIVEN
LookupRow lookupRow = new LookupRow();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public void shouldSerializeToJson() {
row.setField(0, 11);
row.setField(1, StringData.fromString("myUuid"));

this.jsonQueryCreator.createLookupQuery(row);
LookupQueryInfo lookupQuery = this.jsonQueryCreator.createLookupQuery(row);
assertThat(lookupQuery.getBodyBasedUrlQueryParameters().isEmpty());
assertThat(lookupQuery.getLookupQuery()).isEqualTo("{\"id\":11,\"uuid\":\"myUuid\"}");
Expand All @@ -64,8 +63,6 @@ public void shouldSerializeToJsonTwice() {
row.setField(0, 11);
row.setField(1, StringData.fromString("myUuid"));

this.jsonQueryCreator.createLookupQuery(row);

// Call createLookupQuery two times
// to check that serialization schema is not opened Two times.
this.jsonQueryCreator.createLookupQuery(row);
Expand Down

0 comments on commit c277429

Please sign in to comment.