HTTP-119 use default certs when no security configured for https #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
force-pushed
the
http119
branch
3 times, most recently
from
31289fe to
ce52167
Compare
|
@grzegorz8 @kristoffSC Please could you have a look at this one? thanks. |
grzegorz8
requested changes
Oct 17, 2024
src/main/java/com/getindata/connectors/http/internal/utils/JavaNetHttpClientFactory.java
Outdated
Show resolved
Hide resolved
...a/connectors/http/internal/table/lookup/querycreators/ElasticSearchLiteQueryCreatorTest.java
Outdated
Show resolved
Hide resolved
…gured Signed-off-by: davidradl <david_radley@uk.ibm.com>
|
@grzegorz8 I have made the changes - I ended up coding this fresh rather than rebasing - I hope this is ok. |
grzegorz8
approved these changes
Oct 18, 2024
|
@grzegorz8 thanks for merging :-) . Would it be possible to put out a release on this code level? |
https://github.com/getindata/flink-http-connector/actions/runs/11405050253 |
PeatBoy
pushed a commit
to hyperpaas/flink-http-connector
that referenced
this pull request
Jan 21, 2025
…igured (getindata#128) Signed-off-by: davidradl <david_radley@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use default certs when no security configured for https
Resolves
HTTP119PR Checklist