generated from getindata/terraform-module-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Align module with latest Snowflake provider changes (removals and deprecations #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpnoworyta
commented
Jul 25, 2024
dpnoworyta
commented
Jul 25, 2024
dpnoworyta
commented
Jul 25, 2024
moss2k13
reviewed
Jul 26, 2024
…o default db roles
dgniewek
reviewed
Jul 29, 2024
moss2k13
reviewed
Jul 29, 2024
…k simple map for roles
Co-authored-by: Piotr Mossakowski <apps@mossakowski.ch>
dgniewek
requested changes
Aug 1, 2024
dgniewek
requested changes
Aug 1, 2024
dgniewek
approved these changes
Aug 1, 2024
The new version v2.0.0 has been released 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements BREAKING CHANGES!!!
This PR completely rewrites the module, to align it with Snowflake provider latest versions (
>0.94
), implements some code optimizations and changes API (variables) in significant way.List of code and variable (API) changes:
snowflake_database_role
module to leverage newsnowflake_database_roles
mechanism>= v2.1.0
: feat!: Align module with latest Snowflake provider changes (removals and deprecations) terraform-snowflake-stage#16) + feat: Decouple modules to separate database-roles terraform-snowflake-stage#18 to use newly introduced changes by Snowflake providerroles
andstages
variablesadd_grants_to_existing_objects
was removed as it is no longer needed