Skip to content

Files section: use upload i18n string for add button #7051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bezin opened this issue Mar 11, 2025 · 1 comment
Open

Files section: use upload i18n string for add button #7051

bezin opened this issue Mar 11, 2025 · 1 comment

Comments

@bezin
Copy link
Contributor

bezin commented Mar 11, 2025

Description

Even though the underlying action is the same, the files field and files section use different labels for the upload action: The field uses upload whereas the section uses add).

Expected behavior
I would expect both to share the same label (upload, in that case)

Screenshots
Image

Your setup

Kirby 4.6.1

@distantnative
Copy link
Member

Note for future fix:
Currently all models section use the add i18n string and only allow customizing the icon for that button.

We should refactor the buttons computed prop, break it up into smaller parts and make them easier to customize (e.g. having separate addButton etc. computed props).

@distantnative distantnative changed the title Files field and section use different labels for upload action Files section: use upload i18n string for add button Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants