Skip to content

Commit 7bfc603

Browse files
authored
fix(go): Update go cron to include the checkinId (#13922)
## DESCRIBE YOUR PR Go's cron upsert instructions are wrong, and can cause failed checkins as the checkinId is not specified - see discussion on getsentry/sentry#92822 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
1 parent ab17445 commit 7bfc603

File tree

1 file changed

+1
-0
lines changed
  • platform-includes/crons/setup

1 file changed

+1
-0
lines changed

platform-includes/crons/setup/go.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ checkinId := sentry.CaptureCheckIn(
117117
// 🟢 Notify Sentry your job has completed successfully:
118118
sentry.CaptureCheckIn(
119119
&sentry.CheckIn{
120+
ID: *checkinId,
120121
MonitorSlug: "<monitor-slug>",
121122
Status: sentry.CheckInStatusOK,
122123
},

0 commit comments

Comments
 (0)