Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support @sentry/profiling-node #1084

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Support @sentry/profiling-node #1084

wants to merge 4 commits into from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 14, 2025 •
edited
Loading

This PR:

  • Ensures that paths in the profile are normalised to the app root
  • Adds a test to ensure @sentry/profiling-node works with v6.0.0 of the Electron SDK

@timfish timfish requested a review from lforst February 14, 2025 12:04
@timfish timfish marked this pull request as draft February 14, 2025 12:16
@timfish timfish changed the title test: Add test for @sentry/profiling-node feat: Support @sentry/profiling-node Feb 14, 2025
@timfish timfish marked this pull request as ready for review February 14, 2025 12:36
@timfish timfish enabled auto-merge (squash) February 14, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst Awaiting requested review from lforst

@JonasBa JonasBa Awaiting requested review from JonasBa

@andreiborza andreiborza Awaiting requested review from andreiborza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integrate node profiling for electron /express app
1 participant
@timfish