-
-
Notifications
You must be signed in to change notification settings - Fork 452
Determine recording size based on active window #4354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
markushi
wants to merge
11
commits into
main
Choose a base branch
from
markushi/fix/stretched-dialogs-sr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
48b60cb | 398.46 ms | 433.92 ms | 35.46 ms |
168b278 | 427.60 ms | 465.36 ms | 37.76 ms |
52710fb | 449.32 ms | 467.98 ms | 18.66 ms |
dd2d3a5 | 454.46 ms | 493.24 ms | 38.78 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
48b60cb | 1.58 MiB | 2.08 MiB | 507.51 KiB |
168b278 | 1.58 MiB | 2.08 MiB | 507.51 KiB |
52710fb | 1.58 MiB | 2.08 MiB | 511.11 KiB |
dd2d3a5 | 1.58 MiB | 2.08 MiB | 511.10 KiB |
…try/sentry-java into markushi/fix/stretched-dialogs-sr
romtsn
reviewed
May 16, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/ReplayIntegration.kt
Outdated
Show resolved
Hide resolved
* fix(replay): Fix window tracking * api dump
romtsn
approved these changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would need to update tests I guess, but looks good! We'll also have to update Flutter with this change cc @vaind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Instead of relying on the window metrics, we now determine the size based on the top level Window View, once determined the
RecordingConfig
is created and actual recording is started.I couldn't re-use the
onConfigurationChanged
hook, as it removes allrootViews
. But in case of Dialogs, the root views are stacked and as soon as the dialog is popped, no more root view would be available.I tried to apply my changes with minimal impact to the existing structure, happy to restructure it in a better way too, I simply wasn't sure how hybrids consume the existing APIs.
💡 Motivation and Context
Fixes #3574
Fixes #4358
💚 How did you test it?
Manual testing, see e.g. https://sentry-sdks.sentry.io/replays/f278df82391b4b30a7b1cb8b99b15578/?project=5428559&query=&referrer=%2Freplays%2F&statsPeriod=10m&yAxis=count%28%29
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps