Skip to content

fix: sentry-android-ndk proguard rule keeps all native class #4427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
- Use `Sentry.replay().enableDebugMaskingOverlay()` to overlay the screen with the Session Replay masks.
- The masks will be invalidated at most once per `frameRate` (default 1 fps).

### Fixes

- Overly broad Proguard rule in `sentry-android-ndk` keeping all native methods. ([#4427](https://github.com/getsentry/sentry-java/pull/4427))

## 8.12.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion sentry-android-ndk/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
-keep class io.sentry.protocol.DebugImage { *; }

# For native methods, see http://proguard.sourceforge.net/manual/examples.html#native
-keepclasseswithmembernames,includedescriptorclasses class * {
-keepclasseswithmembernames,includedescriptorclasses class io.sentry.** {
native <methods>;
}

Expand Down
Loading