Skip to content

Extend tests to ensure default integrations are registered #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025

Conversation

markushi
Copy link
Member

📜 Description

As another follow-up to #4449, we want to ensure that integrations are registered, both in cases of foreground or background init.

💡 Motivation and Context

SDKs, steady as a rock.

#skip-changelog

💚 How did you test it?

Added tests.

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented May 27, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.96 ms 482.82 ms 78.86 ms
Size 1.58 MiB 2.08 MiB 510.93 KiB

Previous results on branch: markushi/chore/extend-sdk-init-tests

Startup times

Revision Plain With Sentry Diff
76f3c68 434.92 ms 493.54 ms 58.62 ms
d156253 425.88 ms 492.06 ms 66.18 ms
26c62af 407.98 ms 449.69 ms 41.71 ms

App size

Revision Plain With Sentry Diff
76f3c68 1.58 MiB 2.08 MiB 510.84 KiB
d156253 1.58 MiB 2.08 MiB 510.84 KiB
26c62af 1.58 MiB 2.08 MiB 510.84 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope!

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@markushi markushi enabled auto-merge (squash) June 2, 2025 05:42
@markushi markushi merged commit ae8b1a2 into main Jun 2, 2025
32 of 33 checks passed
@markushi markushi deleted the markushi/chore/extend-sdk-init-tests branch June 2, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants