Move compileOnly dependencies to use version catalog #4463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbro112
requested review from
adinauer,
romtsn,
stefanosiano,
markushi and
lcian
as code owners
rbro112
commented
May 29, 2025
| @@ -5,8 +5,6 @@ object Config { | |||
| val AGP = System.getenv("VERSION_AGP") ?: "8.6.0" | |||
| val kotlinStdLib = "stdlib-jdk8" | |||
|
|
|||
| val springBootVersion = "2.7.18" | |||
rbro112
commented
May 29, 2025
| @@ -1,10 +1,11 @@ | |||
| [versions] | |||
| androidxNavigation = "2.4.2" | |||
| androidxTestCore = "1.6.1" | |||
| androidxComposeVersion = "1.6.3" | |||
There was a problem hiding this comment.
Just naming change to remove "Version" as it's redundant
Performance metrics 🚀
|
rbro112
force-pushed
the
ryan/version-catalog-11
branch
from
ae7fd8c to
1cc647f
Compare
runningcode
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Version catalog adoption cont'd
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps