fix: Bundle Sentry SDK dependency #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
approved these changes
Jan 10, 2024
|
We had to rever this because it caused issues with .mjs rollup configs because of the |
|
any update on this? |
|
We released |
3 tasks
AbhiPrasad
added a commit
that referenced
this pull request
Feb 20, 2024
This reverts commit 1c6adf0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: getsentry/sentry-javascript#10121
Ref: getsentry/sentry-javascript#9981 (comment)
We should bundle the SDK dependencies so that we do not facilitate issues with multiple different SDK versions in user's apps.