New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Safely flush telemetry #462

Merged

lforst merged 1 commit into main from lforst-safe-flush

Jan 12, 2024

Member

lforst commented Jan 12, 2024

Fixes #461

I keep forgetting that flushing may throw.


          fix(core): Safely flush telemetry

fef5395

lforst requested a review from Lms24

January 12, 2024 09:38

Lms24 approved these changes

View reviewed changes

Member

Lms24 left a comment

I wonder if this needs fixing on the SDK side. Should it even throw if a flush fails?

Anyway, we should merge this for now to unblock folks

lforst merged commit c493dae into main

16 checks passed

lforst deleted the lforst-safe-flush branch

January 12, 2024 10:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet