feat(webpack): Gate forced process exit behind experimental flag #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Jan 24, 2025
It did, thank you! |
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 25, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.0.0 | 3.1.0 | ## [v3.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#310) - feat(webpack): Gate forced process exit behind experimental flag ([#663](getsentry/sentry-javascript-bundler-plugins#663))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 25, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.0.0 | 3.1.0 | ## [v3.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#310) - feat(webpack): Gate forced process exit behind experimental flag ([#663](getsentry/sentry-javascript-bundler-plugins#663))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #653 I introduced a forced process exit when the webpack build was done. This turned out to happen too early in NextJS builds. My guess is that there are multiple builds in the same process, meaning that we'd exit when the first one is done. This PR now reverts the default behaviour to no longer exit the process. Instead, users can set an experimental flag to force exiting the process (e.g. for #345):
Given we received no confirmation that this actually solves #345 so far, I think keeping this experimental for now is the best option.
fixes #662
probably also addresses #653 (comment)