Google Cloud Functions: Async errors not caught

[martinklepsch]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/serverless 5.26.0

Description

I just tried using sentry/serverless with our Firebase application and can't get it to work at all. One thing that I noticed, which might be considered a bug is that errors thrown from within a promise don't seem to be caught by GCPFunction.wrapHttpFunction. Errors thrown synchronously are caught (as evident by the stacktrace) but also don't seem to be reported to Sentry in my particular case.

Should the wrapHttpFunction catch errors thrown from async evaluations? This forum thread indicates that this is a limitation with GCP. If that's still the case I think this limitation should be documented in the documentation (happy to provide a PR).

Overall I didn't have the best experience trying this and am a bit at a loss on how do debug this further. Is there a way to initialize Sentry in debug mode to get some additional information?

Thanks

[HazAT]

Related: #3325
We don't instrument for unhandled promise rejections in our HTTP wrapper.

[alexbchr]

For reference, here is a duplicated issue on this I believe: #3387

@HazAT So if I understand right, if using @sentry/serverless with Promises, we should do something like:

exports.helloHttp = Sentry.GCPFunction.wrapHttpFunction(async (req, res) => {
  try {
    const something = await fooBar()
    return res.status(200).send()
  } catch (error) {
    Sentry.captureException(error)
    Sentry.flush(1000)
  } 
});

Basically, we have to do the captureException and flush manually, as promises are not handled appropriately on GCP?

I didn't find any mention of this in the Sentry documentation and I feel it should be something that people should be informed on before using the @sentry/serverless library. I believe that most GCP functions people write use Promises and I don't get why this is not already built-in (or at least documented accordingly) in @sentry/serverless. Would be great to have an official example of how to use the library also with Promises.

Is there any plans to support Promises without any workarounds like this? If yes, how soon can we expect this feature?

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀