-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(browser): Add option to sample linked traces consistently #16037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lms24
wants to merge
7
commits into
develop
Choose a base branch
from
lms/feat-browser-sample-previous-trace
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9201af
to
05e5a43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
size-limit report 📦
|
4b39b4a
to
6a87ebe
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6a87ebe
to
45b7e75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements consistent sampling across traces as outlined in #15754. For a detailed write up see the issue.
Concrete changes:
consistentTraceSampling
optionbeforeSampling
hook before sampling and creatingSentrySpan
's in the coreSDK (this hook is already called in Otel-based spans).beforeSampling
hook subscribers to alter spanattributes
andparentSampled
flagbeforeSampling
hook whenconsistentTraceSampling
is enabled andlinkPreviousTrace
is not disabledparentSampled
flag based on the sampling decision, sample rate and sample rand of the previous tracetrace
envelope header. This is necessary to ensure correct span metrics extrapolation.<meta>
tags still have precedence for the first pageload over the previous trace's sampling decision. This is necessary because we need to prioritize inter-trace completeness over intra-trace completenesstracesSampler
still have precedence over the previous trace's sampling decisioncloses #15754