feat: add excepthook handler by default

Author: untitaker

sentry_sdk/client.py

@@ -14,6 +14,14 @@
 _most_recent_exception = ContextVar("sentry_most_recent_exception")
 
 
+def _get_default_integrations():
+    from .integrations.logging import LoggingIntegration
+    from .integrations.excepthook import ExcepthookIntegration
+
+    yield LoggingIntegration
+    yield ExcepthookIntegration
+
+
 class Client(object):
     def __init__(self, dsn=None, *args, **kwargs):
         passed_dsn = dsn
@@ -40,15 +48,12 @@ def __init__(self, dsn=None, *args, **kwargs):
         elif passed_dsn is not None and self._transport is not None:
             raise ValueError("Cannot pass DSN and a custom transport.")
 
-        from .integrations import logging as logging_integration
-
         integrations = list(options.pop("integrations") or ())
 
-        logging_configured = any(
-            isinstance(x, logging_integration.LoggingIntegration) for x in integrations
-        )
-        if not logging_configured and options["default_integrations"]:
-            integrations.append(logging_integration.LoggingIntegration())
+        if options["default_integrations"]:
+            for cls in _get_default_integrations():
+                if not any(isinstance(x, cls) for x in integrations):
+                    integrations.append(cls())
 
         for integration in integrations:
             integration(self)

sentry_sdk/integrations/excepthook.py

@@ -0,0 +1,26 @@
+import sys
+
+from sentry_sdk import capture_exception
+from sentry_sdk.hub import _internal_exceptions
+
+from . import Integration
+
+
+class ExcepthookIntegration(Integration):
+    identifier = "excepthook"
+
+    def __init__(self):
+        pass
+
+    def install(self, client):
+        sys.excepthook = _make_excepthook(sys.excepthook)
+
+
+def _make_excepthook(old_excepthook):
+    def sentry_sdk_excepthook(exctype, value, traceback):
+        with _internal_exceptions():
+            capture_exception((exctype, value, traceback))
+
+        return old_excepthook(exctype, value, traceback)
+
+    return sentry_sdk_excepthook

tests/integrations/excepthook/test_excepthook.py

@@ -0,0 +1,37 @@
+import pytest
+import sys
+import subprocess
+
+from textwrap import dedent
+
+
+def test_excepthook(tmpdir):
+    app = tmpdir.join("app.py")
+    app.write(
+        dedent(
+            """
+    from sentry_sdk import init, transport
+
+    def send_event(pool, event, auth):
+        print("capture event was called")
+        print(event)
+
+    transport.send_event = send_event
+
+    init("http://foobar@localhost/123")
+
+    frame_value = "LOL"
+
+    1/0
+    """
+        )
+    )
+
+    with pytest.raises(subprocess.CalledProcessError) as excinfo:
+        subprocess.check_output([sys.executable, str(app)], stderr=subprocess.STDOUT)
+
+    output = excinfo.value.output
+
+    assert b"ZeroDivisionError" in output
+    assert b"LOL" in output
+    assert b"capture event was called" in output