Skip to content

Commit 4934ab0

Browse files
mdtromdtro
committed
gha: use correct env syntax
1 parent 1bd3359 commit 4934ab0

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

‎.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131

3232
- name: Load env
3333
id: env
34-
run: echo "unityVersion=$(./scripts/ci-env.ps1 "unity${{ env.UNITY_VERSION }}")" >> $env:GITHUB_OUTPUT
34+
run: echo "unityVersion=$(./scripts/ci-env.ps1 "unity${env:UNITY_VERSION}")" >> $env:GITHUB_OUTPUT
3535

3636
- run: echo "::add-mask::${{ secrets.LICENSE_SERVER_URL }}"
3737

@@ -51,7 +51,7 @@ jobs:
5151
password: ${{ secrets.GITHUB_TOKEN }}
5252

5353
- name: Start the Unity docker container
54-
run: ./scripts/ci-docker.sh "${{ env.UNITY_VERSION }}" 'ios' '${{ secrets.UNITY_LICENSE_SERVER_CONFIG }}'
54+
run: ./scripts/ci-docker.sh "${UNITY_VERSION}" 'ios' '${{ secrets.UNITY_LICENSE_SERVER_CONFIG }}'
5555
shell: bash
5656

5757
- name: Install .NET SDK
@@ -61,7 +61,7 @@ jobs:
6161
global-json-file: src/sentry-dotnet/global.json
6262

6363
- name: Install Android dotnet workflow
64-
run: dotnet workload install android --temp-dir "${{ runner.temp }}"
64+
run: dotnet workload install android --temp-dir "${env:RUNNER_TEMP}"
6565

6666
- name: Download CLI
6767
run: ./scripts/download-sentry-cli.ps1

‎.github/workflows/sdk.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
id: env
5050
shell: bash
5151
run: |
52-
if [[ "${{ env.TARGET }}" == "Android" ]]; then
52+
if [[ "${TARGET}" == "Android" ]]; then
5353
submodules="modules/sentry-java"
5454
else
5555
submodules="modules/sentry-native"
@@ -61,7 +61,7 @@ jobs:
6161
- name: Get submodule status
6262
run: git submodule status --cached ${{ steps.env.outputs.submodules }} | tee submodules-status
6363

64-
- run: cp -r package-dev/Plugins/${{ env.TARGET }} sdk-static || echo "never mind, no files checked in..."
64+
- run: cp -r package-dev/Plugins/${TARGET} sdk-static || echo "never mind, no files checked in..."
6565
shell: bash
6666

6767
- name: Restore from cache
@@ -91,7 +91,7 @@ jobs:
9191
if: steps.cache.outputs.cache-hit != 'true'
9292
run: |
9393
git submodule update --init --recursive ${{ steps.env.outputs.submodules }}
94-
dotnet msbuild /t:Build${{ env.TARGET }}SDK /p:Configuration=Release /p:OutDir=other src/Sentry.Unity
94+
dotnet msbuild /t:Build${TARGET}SDK /p:Configuration=Release /p:OutDir=other src/Sentry.Unity
9595
9696
- name: Upload build logs on failure
9797
if: ${{ failure() }}

‎.github/workflows/smoke-test-build-android.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
password: ${{ secrets.GITHUB_TOKEN }}
3535

3636
- name: Start the Unity docker container
37-
run: ./scripts/ci-docker.sh "${{ env.UNITY_VERSION }}" 'android' '${{ secrets.UNITY_LICENSE_SERVER_CONFIG }}'
37+
run: ./scripts/ci-docker.sh "${UNITY_VERSION}" 'android' '${{ secrets.UNITY_LICENSE_SERVER_CONFIG }}'
3838
shell: bash
3939

4040
# Workaround for missing libMonoPosixHelper.so
@@ -63,13 +63,13 @@ jobs:
6363
run: ./test/Scripts.Integration.Test/extract-package.ps1
6464

6565
- name: Add Sentry to the project
66-
run: ./test/Scripts.Integration.Test/add-sentry.ps1 -UnityPath "${{ env.UNITY_PATH }}"
66+
run: ./test/Scripts.Integration.Test/add-sentry.ps1 -UnityPath "${env:UNITY_PATH}"
6767

6868
- name: Configure Sentry
69-
run: ./test/Scripts.Integration.Test/configure-sentry.ps1 -UnityPath "${{ env.UNITY_PATH }}" -Platform "Android" -CheckSymbols
69+
run: ./test/Scripts.Integration.Test/configure-sentry.ps1 -UnityPath "${env:UNITY_PATH}" -Platform "Android" -CheckSymbols
7070

7171
- name: Export APK - Runtime Initialization
72-
run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${{ env.UNITY_PATH }}" -Platform "Android" -CheckSymbols:$true -UnityVersion "${{ env.UNITY_VERSION }}"
72+
run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${env:UNITY_PATH}" -Platform "Android" -CheckSymbols:$true -UnityVersion "${env:UNITY_VERSION}"
7373

7474
- name: Upload .apk
7575
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
@@ -86,7 +86,7 @@ jobs:
8686
Set-Content $optionsPath $content
8787
8888
- name: Export APK - Build-Time Initialization
89-
run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${{ env.UNITY_PATH }}" -Platform "Android" -CheckSymbols:$true -UnityVersion "${{ env.UNITY_VERSION }}"
89+
run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${env:UNITY_PATH}" -Platform "Android" -CheckSymbols:$true -UnityVersion "${env:UNITY_VERSION}"
9090

9191
- name: Upload .apk
9292
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4

‎.github/workflows/smoke-test-build-ios.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
password: ${{ secrets.GITHUB_TOKEN }}
4141

4242
- name: Start the Unity docker container
43-
run: ./scripts/ci-docker.sh "${{ env.UNITY_VERSION }}" 'iOS' '${{ secrets.UNITY_LICENSE_SERVER_CONFIG }}'
43+
run: ./scripts/ci-docker.sh "${UNITY_VERSION}" 'iOS' '${{ secrets.UNITY_LICENSE_SERVER_CONFIG }}'
4444
shell: bash
4545

4646
# Workaround for missing libMonoPosixHelper.so
@@ -69,13 +69,13 @@ jobs:
6969
run: ./test/Scripts.Integration.Test/extract-package.ps1
7070

7171
- name: Add Sentry to the project
72-
run: ./test/Scripts.Integration.Test/add-sentry.ps1 -UnityPath "${{ env.UNITY_PATH }}"
72+
run: ./test/Scripts.Integration.Test/add-sentry.ps1 -UnityPath "${env:UNITY_PATH}"
7373

7474
- name: Configure Sentry
75-
run: ./test/Scripts.Integration.Test/configure-sentry.ps1 -UnityPath "${{ env.UNITY_PATH }}" -Platform ${{ matrix.build_platform }} -CheckSymbols
75+
run: ./test/Scripts.Integration.Test/configure-sentry.ps1 -UnityPath "${env:UNITY_PATH}" -Platform ${{ matrix.build_platform }} -CheckSymbols
7676

7777
- name: Build Project
78-
run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${{ env.UNITY_PATH }}" -Platform ${{ matrix.build_platform }} -CheckSymbols:$false -UnityVersion "${{ env.UNITY_VERSION }}"
78+
run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${env:UNITY_PATH}" -Platform ${{ matrix.build_platform }} -CheckSymbols:$false -UnityVersion "${env:UNITY_VERSION}"
7979

8080
# We create tar explicitly because upload-artifact is slow for many files.
8181
- name: Create archive
@@ -102,7 +102,7 @@ jobs:
102102
Set-Content $optionsPath $content
103103
104104
- name: Build Project for mobile platforms (build-time initialization)
105-
run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${{ env.UNITY_PATH }}" -Platform ${{ matrix.build_platform }} -CheckSymbols:$false -UnityVersion "${{ env.UNITY_VERSION }}"
105+
run: ./test/Scripts.Integration.Test/build-project.ps1 -UnityPath "${env:UNITY_PATH}" -Platform ${{ matrix.build_platform }} -CheckSymbols:$false -UnityVersion "${env:UNITY_VERSION}"
106106

107107
- name: Create archive (build-time initialization)
108108
shell: bash

‎.github/workflows/smoke-test-compile-ios.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ jobs:
3131
name: testapp-ios-${{ env.UNITY_VERSION }}-${{ env.INIT_TYPE }}
3232

3333
- name: Extract app project
34-
run: tar -xvzf test-app-${{ env.INIT_TYPE }}.tar.gz
34+
run: tar -xvzf test-app-${env:INIT_TYPE}.tar.gz
3535

3636
- name: iOS smoke test
37-
run: ./scripts/smoke-test-ios.ps1 Build -IsIntegrationTest -UnityVersion "${{ env.UNITY_VERSION }}" -iOSMinVersion "16.1"
37+
run: ./scripts/smoke-test-ios.ps1 Build -IsIntegrationTest -UnityVersion "${env:UNITY_VERSION}" -iOSMinVersion "16.1"
3838
timeout-minutes: 20
3939

4040
- name: Upload integration-test project on failure

‎.github/workflows/smoke-test-run-ios.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
id: smoke-test
5858
timeout-minutes: 20
5959
run: |
60-
$runtime = "${{ env.IOS_VERSION }}"
60+
$runtime = "${env:IOS_VERSION}"
6161
If ($runtime -ne "latest")
6262
{
6363
$runtime = "iOS " + $runtime

0 commit comments

Comments
 (0)