Skip to content

ci: use envs in GHAs and pin versions #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025
Merged

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented May 28, 2025

@mdtro mdtro requested a review from bitsandfoxes as a code owner May 28, 2025 14:10
@mdtro mdtro requested review from bruno-garcia and a team and removed request for bitsandfoxes May 28, 2025 14:19
Copy link
Member

@Jeffreyhung Jeffreyhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdtro I noticed you updated quite a few variable references from double curly brace to single curly brace
e.g ${{ inputs.unity-version }}' to "${UNITY_VERSION}"
Is that on purpose?

@mdtro
Copy link
Member Author

mdtro commented May 28, 2025

@mdtro I noticed you updated quite a few variable references from double curly brace to single curly brace e.g ${{ inputs.unity-version }}' to "${UNITY_VERSION}" Is that on purpose?

Yes, it is intentional. With double curly brackets ${{...}} it is still using GHA's template expansion. Instead, those values are set in the env: clauses at the top of the workflow, job, or particular step -- depending on where they're needed.

Using single brackets ${VARNAME} means the environment variable is used and the shell itself does the variable expansion.

@bruno-garcia
Copy link
Member

Thanks for opening this.

cc @getsentry/gdx @tustanivsky @vaind @jamescrosswell @limbonaut @bitsandfoxes something to keep in mind going forward

Co-authored-by: Serhii Snitsaruk <limbonaut@pm.me>
@mdtro mdtro merged commit 11b9e4d into main Jun 6, 2025
6 checks passed
@mdtro mdtro deleted the mdtro/gha-prevent-injection branch June 6, 2025 16:19
mdtro added a commit that referenced this pull request Jun 6, 2025
mdtro added a commit that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants