Remove legacy ReleaseBundle code (#90166)

We have had some code previously for the older version of
`ArtifactBundle` (named `ReleaseBundle`), which was being used for a
legacy upload endpoint, but was changed over to create `ArtifactBundle`s
instead via a feature flag.

That feature flag was hardcoded to always use the newer `ArtifactBundle`
codepath over a year ago. But the legacy `ReleaseBundle` codepath has
never been cleaned up. Until today 🎉

Author: Swatinem

src/sentry/api/endpoints/organization_artifactbundle_assemble.py

@@ -163,7 +163,6 @@ def post(self, request: Request, organization) -> Response:
                         "dist": dist,
                         "checksum": checksum,
                         "chunks": chunks,
-                        "upload_as_artifact_bundle": True,
                     }
                 )
 

src/sentry/api/endpoints/organization_release_assemble.py

@@ -63,20 +63,12 @@ def post(self, request: Request, organization, version) -> Response:
         checksum = data.get("checksum", None)
         chunks = data.get("chunks", [])
 
-        upload_as_artifact_bundle = True
-        is_release_bundle_migration = True
         # NOTE: this list of projects can be further refined based on the
         # `project` embedded in the bundle manifest.
         project_ids = [project.id for project in release.projects.all()]
         metrics.incr("sourcemaps.upload.release_as_artifact_bundle")
 
-        assemble_task = (
-            AssembleTask.ARTIFACT_BUNDLE
-            if upload_as_artifact_bundle
-            else AssembleTask.RELEASE_BUNDLE
-        )
-
-        state, detail = get_assemble_status(assemble_task, organization.id, checksum)
+        state, detail = get_assemble_status(AssembleTask.ARTIFACT_BUNDLE, organization.id, checksum)
         if state == ChunkFileState.OK:
             return Response({"state": state, "detail": None, "missingChunks": []}, status=200)
         elif state is not None:
@@ -88,7 +80,9 @@ def post(self, request: Request, organization, version) -> Response:
         if not chunks:
             return Response({"state": ChunkFileState.NOT_FOUND, "missingChunks": []}, status=200)
 
-        set_assemble_status(assemble_task, organization.id, checksum, ChunkFileState.CREATED)
+        set_assemble_status(
+            AssembleTask.ARTIFACT_BUNDLE, organization.id, checksum, ChunkFileState.CREATED
+        )
 
         from sentry.tasks.assemble import assemble_artifacts
 
@@ -101,8 +95,7 @@ def post(self, request: Request, organization, version) -> Response:
                 # NOTE: The `dist` is embedded in the Bundle manifest and optional here.
                 # It will be backfilled from the manifest within the `assemble_artifacts` task.
                 "project_ids": project_ids,
-                "upload_as_artifact_bundle": upload_as_artifact_bundle,
-                "is_release_bundle_migration": is_release_bundle_migration,
+                "is_release_bundle_migration": True,
             }
         )
 

src/sentry/api/endpoints/project_release_files.py

@@ -125,7 +125,22 @@ def post_releasefile(request, release, logger):
                 {"detail": "File name must not contain special whitespace characters"}, status=400
             )
 
+        headers = {"Content-Type": fileobj.content_type}
+        for headerval in request.data.getlist("header") or ():
+            try:
+                k, v = headerval.split(":", 1)
+            except ValueError:
+                return Response({"detail": "header value was not formatted correctly"}, status=400)
+            else:
+                if _filename_re.search(v):
+                    return Response(
+                        {"detail": "header value must not contain special whitespace characters"},
+                        status=400,
+                    )
+                headers[k] = v.strip()
+
         dist_name = request.data.get("dist")
+
         dist = None
         if dist_name:
             dist = release.add_dist(dist_name)
@@ -140,20 +155,6 @@ def post_releasefile(request, release, logger):
         ).exists():
             return Response({"detail": ERR_FILE_EXISTS}, status=409)
 
-        headers = {"Content-Type": fileobj.content_type}
-        for headerval in request.data.getlist("header") or ():
-            try:
-                k, v = headerval.split(":", 1)
-            except ValueError:
-                return Response({"detail": "header value was not formatted correctly"}, status=400)
-            else:
-                if _filename_re.search(v):
-                    return Response(
-                        {"detail": "header value must not contain special whitespace characters"},
-                        status=400,
-                    )
-                headers[k] = v.strip()
-
         file = File.objects.create(name=name, type="release.file", headers=headers)
         file.putfile(fileobj, logger=logger)