Revert "type a load of formfield configs"

This reverts commit 8ef4856.

Author: Christinarlong

src/sentry/integrations/jira/endpoints/search.py

@@ -10,7 +10,6 @@
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import control_silo_endpoint
 from sentry.integrations.api.bases.integration import IntegrationEndpoint
-from sentry.integrations.jira.integration import JiraProjectMapping
 from sentry.integrations.models.integration import Integration
 from sentry.organizations.services.organization import RpcOrganization
 from sentry.shared_integrations.exceptions import ApiError, ApiUnauthorized, IntegrationError
@@ -95,7 +94,7 @@ def get(
                 return Response({"detail": "Unable to fetch projects from Jira"}, status=400)
 
             projects = [
-                JiraProjectMapping(label=f"{p["key"]} - {p["name"]}", value=p["id"])
+                {"label": f"{p["key"]} - {p["name"]}", "value": p["id"]}
                 for p in response.get("values", [])
             ]
 

src/sentry/integrations/jira/integration.py

@@ -23,12 +23,7 @@
 )
 from sentry.integrations.jira.models.create_issue_metadata import JiraIssueTypeMetadata
 from sentry.integrations.jira.tasks import migrate_issues
-from sentry.integrations.mixins.issues import (
-    MAX_CHAR,
-    BaseFormFieldConfig,
-    IssueSyncIntegration,
-    ResolveSyncAction,
-)
+from sentry.integrations.mixins.issues import MAX_CHAR, IssueSyncIntegration, ResolveSyncAction
 from sentry.integrations.models.external_issue import ExternalIssue
 from sentry.integrations.models.integration_external_project import IntegrationExternalProject
 from sentry.integrations.services.integration import integration_service
@@ -133,15 +128,6 @@ class JiraProjectMapping(TypedDict):
     label: str
 
 
-class SelectFormFieldConfig(BaseFormFieldConfig, total=False):
-    choices: list[tuple[str, str]]
-    updatesForm: bool
-
-
-class AsyncSelectFormFieldConfig(SelectFormFieldConfig):
-    url: str
-
-
 class JiraIntegration(IssueSyncIntegration):
     outbound_status_key = "sync_status_forward"
     inbound_status_key = "sync_status_reverse"
@@ -842,41 +828,33 @@ def get_create_issue_config(self, group: Group | None, user: RpcUser, **kwargs):
             if not any(c for c in issue_type_choices if c[0] == issue_type):
                 issue_type = issue_type_meta["id"]
 
-        projects_form_field = SelectFormFieldConfig(
-            name="project",
-            label="Jira Project",
-            choices=[(p["id"], f"{p["key"]} - {p["name"]}") for p in jira_projects],
-            default=meta["id"],
-            type="select",
-            updatesForm=True,
-            required=True,
-        )
-
+        projects_form_field = {
+            "name": "project",
+            "label": "Jira Project",
+            "choices": [(p["id"], f"{p["key"]} - {p["name"]}") for p in jira_projects],
+            "default": meta["id"],
+            "type": "select",
+            "updatesForm": True,
+            "required": True,
+        }
         if features.has("organizations:jira-paginated-projects", group.organization, actor=user):
-            paginated_projects_url = self.search_url(group.organization.slug)
-            projects_form_field = AsyncSelectFormFieldConfig(
-                name="project",
-                label="Jira Project",
-                choices=[(p["id"], f"{p["key"]} - {p["name"]}") for p in jira_projects],
-                default=meta["id"],
-                type="select",
-                updatesForm=True,
-                required=True,
-                url=paginated_projects_url,
+            paginated_projects_url = reverse(
+                "sentry-extensions-jira-search", args=[self.organization.slug, self.model.id]
             )
+            projects_form_field["url"] = paginated_projects_url
 
         fields = [
             projects_form_field,
             *fields,
-            SelectFormFieldConfig(
-                name="issuetype",
-                label="Issue Type",
-                choices=issue_type_choices,
-                default=issue_type or issue_type_meta["id"],
-                type="select",
-                updatesForm=True,
-                required=bool(issue_type_choices),
-            ),
+            {
+                "name": "issuetype",
+                "label": "Issue Type",
+                "default": issue_type or issue_type_meta["id"],
+                "type": "select",
+                "choices": issue_type_choices,
+                "updatesForm": True,
+                "required": bool(issue_type_choices),  # required if we have any type choices
+            },
         ]
 
         # title is renamed to summary before sending to Jira

src/sentry/integrations/mixins/issues.py

@@ -7,7 +7,7 @@
 from collections.abc import Mapping, Sequence
 from copy import deepcopy
 from operator import attrgetter
-from typing import Any, ClassVar, TypedDict
+from typing import Any, ClassVar
 
 from sentry.eventstore.models import GroupEvent
 from sentry.integrations.base import IntegrationInstallation
@@ -35,19 +35,6 @@
 MAX_CHAR = 50
 
 
-class BaseFormFieldConfig(TypedDict):
-    name: str
-    label: str
-    default: str
-    type: str
-    required: bool
-
-
-class TextAreaFormFieldConfig(BaseFormFieldConfig, total=False):
-    autosize: bool
-    maxRows: int
-
-
 class ResolveSyncAction(enum.Enum):
     """
     When an issue's state changes, we may have to sync the state based on the
@@ -157,7 +144,7 @@ def get_group_description(self, group, event, **kwargs):
     @all_silo_function
     def get_create_issue_config(
         self, group: Group | None, user: User | RpcUser, **kwargs
-    ) -> list[BaseFormFieldConfig]:
+    ) -> list[dict[str, Any]]:
         """
         These fields are used to render a form for the user,
         and are then passed in the format of:
@@ -173,22 +160,21 @@ def get_create_issue_config(
         event = group.get_latest_event()
 
         return [
-            BaseFormFieldConfig(
-                name="title",
-                label="Title",
-                default=self.get_group_title(group, event, **kwargs),
-                type="string",
-                required=True,
-            ),
-            TextAreaFormFieldConfig(
-                name="description",
-                label="Description",
-                default=self.get_group_description(group, event, **kwargs),
-                type="textarea",
-                autosize=True,
-                maxRows=10,
-                required=False,
-            ),
+            {
+                "name": "title",
+                "label": "Title",
+                "default": self.get_group_title(group, event, **kwargs),
+                "type": "string",
+                "required": True,
+            },
+            {
+                "name": "description",
+                "label": "Description",
+                "default": self.get_group_description(group, event, **kwargs),
+                "type": "textarea",
+                "autosize": True,
+                "maxRows": 10,
+            },
         ]
 
     def get_link_issue_config(self, group, **kwargs):