Skip to content

Commit 09b4b3e

Browse files
authored
feat(insights): Replace cache hit/miss chart in span sample panel with InsightsTimeSeriesWidget (#89642)
2EZ Closes [DAIN-171: Replace `CacheHitMissChart` with `InsightsTimeSeriesWidget`](https://linear.app/getsentry/issue/DAIN-171/replace-cachehitmisschart-with-insightstimeserieswidget)
1 parent ec32170 commit 09b4b3e

File tree

1 file changed

+10
-30
lines changed

1 file changed

+10
-30
lines changed
Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,21 @@
1-
import {useTheme} from '@emotion/react';
2-
3-
import type {Series} from 'sentry/types/echarts';
4-
import {formatPercentage} from 'sentry/utils/number/formatPercentage';
5-
import {CHART_HEIGHT} from 'sentry/views/insights/cache/settings';
6-
import {AVG_COLOR} from 'sentry/views/insights/colors';
7-
import Chart, {ChartType} from 'sentry/views/insights/common/components/chart';
8-
import ChartPanel from 'sentry/views/insights/common/components/chartPanel';
1+
import {InsightsLineChartWidget} from 'sentry/views/insights/common/components/insightsLineChartWidget';
2+
import type {DiscoverSeries} from 'sentry/views/insights/common/queries/useDiscoverSeries';
93
import {DataTitles} from 'sentry/views/insights/common/views/spans/types';
104

115
type Props = {
126
isLoading: boolean;
13-
series: Series;
7+
series: DiscoverSeries;
148
error?: Error | null;
159
};
1610

1711
export function CacheHitMissChart({series, isLoading, error}: Props) {
18-
const theme = useTheme();
1912
return (
20-
<ChartPanel title={DataTitles[`cache_miss_rate()`]}>
21-
<Chart
22-
height={CHART_HEIGHT}
23-
grid={{
24-
left: '4px',
25-
right: '0',
26-
top: '8px',
27-
bottom: '0',
28-
}}
29-
data={[series]}
30-
loading={isLoading}
31-
error={error}
32-
chartColors={[AVG_COLOR(theme)]}
33-
type={ChartType.LINE}
34-
aggregateOutputFormat="percentage"
35-
tooltipFormatterOptions={{
36-
valueFormatter: value => formatPercentage(value),
37-
}}
38-
/>
39-
</ChartPanel>
13+
<InsightsLineChartWidget
14+
title={DataTitles[`cache_miss_rate()`]}
15+
series={[series]}
16+
showLegend="never"
17+
isLoading={isLoading}
18+
error={error ?? null}
19+
/>
4020
);
4121
}

0 commit comments

Comments
 (0)