Skip to content

Commit 1247e00

Browse files
authored
ref: remove react-resizable imports (#92291)
This PR removes css imports from `react-resizable`, as we don't have `react-resizable` as a dependency in `package.json`. It’s a pre-requisite to enable the lint rule [import/no-extraneous-dependencies](https://github.com/import-js/eslint-plugin-import/blob/da5f6ec13160cb288338db0c2a00c34b2d932f0d/docs/rules/no-extraneous-dependencies.md). `react-resizable` is a dependency of `react-grid-layout`, which we do use. The import we have only adds styles for the resizable handle, which `react-grid-layout` also adds. I’ve tested this change on the dashboard page, and the resize handle still looks like and works exactly like before. I’m unsure where to find `gridPreview/index.tsx`, but I doubt that it would behave differently.
1 parent ab151d5 commit 1247e00

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

static/app/views/dashboards/dashboard.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'react-grid-layout/css/styles.css';
2-
import 'react-resizable/css/styles.css';
32

43
import {Component} from 'react';
54
import type {Layouts} from 'react-grid-layout';

static/app/views/dashboards/manage/gridPreview/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'react-grid-layout/css/styles.css';
2-
import 'react-resizable/css/styles.css';
32

43
import GridLayout, {WidthProvider} from 'react-grid-layout';
54
import styled from '@emotion/styled';

0 commit comments

Comments
 (0)