Skip to content

Commit 13e132f

Browse files
refactor(codecov): Move around onboarding file org
1 parent 467933d commit 13e132f

File tree

7 files changed

+12
-85
lines changed

7 files changed

+12
-85
lines changed

static/app/routes.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2022,9 +2022,7 @@ function buildRoutes() {
20222022
{/* Render tests onboarding without any layout wrapping */}
20232023
<Route
20242024
path="new/"
2025-
component={make(
2026-
() => import('sentry/views/codecov/tests/onboarding/onboarding')
2027-
)}
2025+
component={make(() => import('sentry/views/codecov/tests/onboarding'))}
20282026
/>
20292027
</Route>
20302028
<Route path="tokens/">

static/app/views/codecov/tests/onboarding.tsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ import styled from '@emotion/styled';
55
import RadioGroup from 'sentry/components/forms/controls/radioGroup';
66
import {t} from 'sentry/locale';
77
import {space} from 'sentry/styles/space';
8+
import {OutputCoverageFile} from 'sentry/views/codecov/tests/onboardingSteps/outputCoverageFile';
9+
import TestPreOnboardingPage from 'sentry/views/codecov/tests/preOnboarding';
810

911
type SetupOption = 'githubAction' | 'cli';
1012

11-
// Phase out for directory version
1213
export default function TestsOnboardingPage() {
1314
const [searchParams, setSearchParams] = useSearchParams();
1415
const opt = searchParams.get('opt');
@@ -23,6 +24,7 @@ export default function TestsOnboardingPage() {
2324
return (
2425
<LayoutGap>
2526
<p>Test Analytics Onboarding</p>
27+
<TestPreOnboardingPage />
2628
<OnboardingContainer>
2729
<IntroContainer>
2830
<GetStartedHeader>{t('Get Started with Test Analytics')}</GetStartedHeader>
@@ -42,6 +44,9 @@ export default function TestsOnboardingPage() {
4244
['cli', t("Use Sentry Prevent's CLI to upload testing reports")],
4345
]}
4446
/>
47+
<StepsContainer>
48+
<OutputCoverageFile stepString="1" />
49+
</StepsContainer>
4550
</OnboardingContainer>
4651
</LayoutGap>
4752
);
@@ -79,3 +84,7 @@ const SelectOptionHeader = styled('h5')`
7984
color: ${p => p.theme.tokens.content.primary};
8085
margin-top: ${space(3)};
8186
`;
87+
88+
const StepsContainer = styled('div')`
89+
padding: ${space(3)} ${space(4)};
90+
`;

static/app/views/codecov/tests/onboarding/onboarding.tsx

Lines changed: 0 additions & 78 deletions
This file was deleted.

static/app/views/codecov/tests/onboarding/outputCoverageFile.tsx renamed to static/app/views/codecov/tests/onboardingSteps/outputCoverageFile.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {CodeSnippet} from 'sentry/components/codeSnippet';
66
import {Select} from 'sentry/components/core/select';
77
import {t, tct} from 'sentry/locale';
88
import {space} from 'sentry/styles/space';
9-
import {OnboardingStep} from 'sentry/views/codecov/tests/onboarding/onboardingStep';
9+
import {OnboardingStep} from 'sentry/views/codecov/tests/onboardingSteps/onboardingStep';
1010

1111
interface OutputCoverageFileProps {
1212
stepString: string;

static/app/views/codecov/tests/tests.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {DatePicker} from 'sentry/components/codecov/datePicker/datePicker';
44
import PageFilterBar from 'sentry/components/organizations/pageFilterBar';
55
import PageFiltersContainer from 'sentry/components/organizations/pageFilters/container';
66
import {space} from 'sentry/styles/space';
7-
import TestsOnboardingPage from 'sentry/views/codecov/tests/onboarding/onboarding';
87
import {Summaries} from 'sentry/views/codecov/tests/summaries/summaries';
98

109
const DEFAULT_CODECOV_DATETIME_SELECTION = {
@@ -27,7 +26,6 @@ export default function TestsPage() {
2726
</PageFiltersContainer>
2827
{/* TODO: Conditionally show these if the branch we're in is the main branch */}
2928
<Summaries />
30-
<TestsOnboardingPage />
3129
</LayoutGap>
3230
);
3331
}

0 commit comments

Comments
 (0)