wip

Author: DominikB2014

src/sentry/sentry_metrics/indexer/strings.py

@@ -226,6 +226,7 @@
     "d:spans/webvital.score.weight.inp@ratio": PREFIX + 416,
     "d:spans/webvital.inp@millisecond": PREFIX + 417,
     "c:spans/usage@none": PREFIX + 418,
+    "d:spans/cache.item_size@byte": PREFIX + 419,
     # Last possible index: 499
 }
 

tests/snuba/api/endpoints/test_organization_events_stats_span_metrics.py

@@ -275,7 +275,7 @@ def test_cache_item_size(self):
             4,
             metric="cache.item_size",
             timestamp=self.day_ago + timedelta(minutes=1),
-            tags={"transaction": "foo", "cache.hit": "true"},
+            tags={"transaction": "foo"},
         )
 
         response = self.do_request(
@@ -287,7 +287,6 @@ def test_cache_item_size(self):
                 "project": self.project.id,
                 "dataset": "spansMetrics",
                 "excludeOther": 0,
-                "field": ["cache.hit"],
             },
         )
 
@@ -298,6 +297,28 @@ def test_cache_item_size(self):
         assert not data[0][1][0]["count"]
         assert data[1][1][0]["count"] == 4.0
 
+    def test_cache_hit(self):
+        self.store_span_metric(
+            4,
+            metric="cache.item_size",
+            timestamp=self.day_ago + timedelta(minutes=1),
+            tags={"cache.hit": "true", "transaction": "foo"},
+        )
+
+        response = self.do_request(
+            data={
+                "start": iso_format(self.day_ago),
+                "end": iso_format(self.day_ago + timedelta(minutes=2)),
+                "interval": "1m",
+                "field": ["transaction"],
+                "yAxis": ["count()"],
+                "project": self.project.id,
+                "dataset": "spansMetrics",
+            },
+        )
+
+        assert response.status_code == 200
+
 
 class OrganizationEventsStatsSpansMetricsEndpointTestWithMetricLayer(
     OrganizationEventsStatsSpansMetricsEndpointTest