fix(quick-start): Task not marked as seen when sidebar is open (#91702)

Author: priscilawebdev

static/app/components/onboardingWizard/content.tsx

@@ -335,6 +335,11 @@ function ExpandedTaskGroup({sortedTasks, hidePanel}: ExpandedTaskGroupProps) {
 
   const markCompletionTimeout = useRef<number | undefined>(undefined);
 
+  const unseenDoneTasks = useMemo(
+    () => sortedTasks.filter(task => taskIsDone(task) && !task.completionSeen),
+    [sortedTasks]
+  );
+
   function completionTimeout(time: number): Promise<void> {
     window.clearTimeout(markCompletionTimeout.current);
     return new Promise(resolve => {
@@ -343,16 +348,16 @@ function ExpandedTaskGroup({sortedTasks, hidePanel}: ExpandedTaskGroupProps) {
   }
 
   const markTasksAsSeen = useCallback(() => {
-    const unseenDoneTasks = sortedTasks
+    const tasksToMarkComplete = sortedTasks
       .filter(task => taskIsDone(task) && !task.completionSeen)
       .map(task => ({...task, completionSeen: true}));
 
     if (isDemoModeActive()) {
-      for (const unseenDoneTask of unseenDoneTasks) {
-        updateDemoWalkthroughTask(unseenDoneTask);
+      for (const task of tasksToMarkComplete) {
+        updateDemoWalkthroughTask(task);
       }
     } else {
-      mutateOnboardingTasks.mutate(unseenDoneTasks);
+      mutateOnboardingTasks.mutate(tasksToMarkComplete);
     }
   }, [mutateOnboardingTasks, sortedTasks]);
 
@@ -367,11 +372,14 @@ function ExpandedTaskGroup({sortedTasks, hidePanel}: ExpandedTaskGroupProps) {
   );
 
   useEffect(() => {
-    markSeenOnOpen();
+    if (unseenDoneTasks.length > 0) {
+      markSeenOnOpen();
+    }
+
     return () => {
       window.clearTimeout(markCompletionTimeout.current);
     };
-  }, []); // eslint-disable-line react-hooks/exhaustive-deps
+  }, [unseenDoneTasks, markSeenOnOpen]);
 
   return (
     <Fragment>