Skip to content

Commit 19b5c20

Browse files
wedamijaandrewshie-sentry
authored andcommitted
feat(uptime): Switch uptime grouptype to use flagpole (#89363)
We've created the appropriate feature flags in options automator, so now we can switch uptime over to use these flags instead of the option backed flags. <!-- Describe your PR here. -->
1 parent 4460933 commit 19b5c20

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

src/sentry/issues/grouptype.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -666,6 +666,7 @@ class UptimeDomainCheckFailure(GroupType):
666666
},
667667
"additionalProperties": False,
668668
}
669+
use_flagpole_for_all_features = True
669670

670671

671672
@dataclass(frozen=True)

tests/sentry/uptime/consumers/test_results_consumer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def send_result(
7979
datetime.now(),
8080
)
8181
)
82-
with self.feature(UptimeDomainCheckFailure.build_ingest_feature_name()):
82+
with self.feature(UptimeDomainCheckFailure.build_ingest_flagpole_feature_name()):
8383
if consumer is None:
8484
factory = UptimeResultsStrategyFactory(mode=self.strategy_processing_mode)
8585
commit = mock.Mock()

tests/sentry/uptime/subscriptions/test_subscriptions.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,10 @@ def test(self, mock_disable_seat):
690690

691691
@mock.patch("sentry.quotas.backend.disable_seat")
692692
def test_disable_failed(self, mock_disable_seat):
693-
with self.tasks(), self.feature(UptimeDomainCheckFailure.build_ingest_feature_name()):
693+
with (
694+
self.tasks(),
695+
self.feature(UptimeDomainCheckFailure.build_ingest_flagpole_feature_name()),
696+
):
694697
proj_sub = create_project_uptime_subscription(
695698
self.project,
696699
self.environment,

tests/sentry/uptime/test_issue_platform.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def test(self):
119119
uptime_subscription=subscription
120120
)
121121
result = self.create_uptime_result(subscription.subscription_id)
122-
with self.feature(UptimeDomainCheckFailure.build_ingest_feature_name()):
122+
with self.feature(UptimeDomainCheckFailure.build_ingest_flagpole_feature_name()):
123123
create_issue_platform_occurrence(result, project_subscription)
124124
hashed_fingerprint = md5(str(project_subscription.id).encode("utf-8")).hexdigest()
125125
group = Group.objects.get(grouphash__hash=hashed_fingerprint)

0 commit comments

Comments
 (0)