Skip to content

Commit 1e08e16

Browse files
fix(chartcuterie): query event when needed (#70057)
Fetching event might throw error so putting it where the try catch is. Also event is not needed till later.
1 parent 1730d73 commit 1e08e16

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

src/sentry/integrations/slack/message_builder/image_block_builder.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ class ImageBlockBuilder(BlockSlackMessageBuilder):
2525
def __init__(self, group: Group) -> None:
2626
super().__init__()
2727
self.group = group
28-
self.event = group.get_latest_event_for_environments()
2928

3029
def build_image_block(self) -> SlackBlock | None:
3130
if (
@@ -45,13 +44,13 @@ def _build_endpoint_regression_image_block(self) -> SlackBlock | None:
4544
},
4645
)
4746

48-
organization = self.group.organization
49-
if self.event is None or self.event.transaction is None or self.event.occurrence is None:
50-
return None
51-
transaction_name = escape_transaction(self.event.transaction)
52-
period = get_relative_time(anchor=get_approx_start_time(self.group), relative_days=14)
53-
5447
try:
48+
organization = self.group.organization
49+
event = self.group.get_latest_event_for_environments()
50+
if event is None or event.transaction is None or event.occurrence is None:
51+
return None
52+
transaction_name = escape_transaction(event.transaction)
53+
period = get_relative_time(anchor=get_approx_start_time(self.group), relative_days=14)
5554
resp = client.get(
5655
auth=ApiKey(organization_id=organization.id, scope_list=["org:read"]),
5756
user=None,
@@ -70,7 +69,7 @@ def _build_endpoint_regression_image_block(self) -> SlackBlock | None:
7069
url = charts.generate_chart(
7170
ChartType.SLACK_PERFORMANCE_ENDPOINT_REGRESSION,
7271
data={
73-
"evidenceData": self.event.occurrence.evidence_data,
72+
"evidenceData": event.occurrence.evidence_data,
7473
"percentileData": resp.data["p95(transaction.duration)"]["data"],
7574
},
7675
)

0 commit comments

Comments
 (0)