cmt

Author: vishnupsatish

src/sentry/feedback/usecases/create_feedback.py

@@ -507,23 +507,7 @@ def shim_to_feedback(
             },
         }
 
-        # An invalid event_id leads to tracking the outcome and dropping the feedback
-        try:
-            UUID(event.event_id, version=4)
-            feedback_event["contexts"]["feedback"]["associated_event_id"] = event.event_id
-        except ValueError:
-            track_outcome(
-                org_id=project.organization_id,
-                project_id=project.id,
-                key_id=None,
-                outcome=Outcome.INVALID,
-                reason="invalid_event_id",
-                timestamp=datetime.fromisoformat(event.timestamp),
-                event_id=event.event_id,
-                category=DataCategory.USER_REPORT_V2,
-                quantity=1,
-            )
-            return
+        feedback_event["contexts"]["feedback"]["associated_event_id"] = event.event_id
 
         if get_path(event.data, "contexts", "replay", "replay_id"):
             feedback_event["contexts"]["replay"] = event.data["contexts"]["replay"]

tests/sentry/feedback/usecases/test_create_feedback.py

@@ -789,7 +789,7 @@ def test_create_feedback_adds_associated_event_id(
 
 
 @django_db_all
-def test_create_feedback_adds_invalid_associated_event_id(
+def test_create_feedback_excludes_invalid_associated_event_id(
     default_project, mock_produce_occurrence_to_kafka
 ):
     event = {
@@ -839,6 +839,10 @@ def test_create_feedback_adds_invalid_associated_event_id(
     associated_event_id = associated_event_id_evidence[0] if associated_event_id_evidence else None
     assert associated_event_id is None
 
+    produced_event = mock_produce_occurrence_to_kafka.call_args.kwargs["event_data"]
+    assert produced_event["tags"]["has_linked_error"] == "false"
+    assert not produced_event["contexts"]["feedback"].get("associated_event_id")
+
 
 @django_db_all
 def test_create_feedback_tags(default_project, mock_produce_occurrence_to_kafka):