fix(ourlogs): Make the alias for 'severity_text' be 'severity' (#90063)

This aligns the alias with the displayed column.

Author: colin-sentry

src/sentry/search/eap/ourlogs/attributes.py

@@ -28,7 +28,7 @@
             search_type="integer",
         ),
         ResolvedAttribute(
-            public_alias="severity_text",
+            public_alias="severity",
             internal_name="sentry.severity_text",
             search_type="string",
         ),
@@ -66,6 +66,12 @@
             secondary_alias=True,
         ),
         # Deprecated
+        ResolvedAttribute(
+            public_alias="severity_text",
+            internal_name="sentry.severity_text",
+            search_type="string",
+            secondary_alias=True,
+        ),
         ResolvedAttribute(
             public_alias="log.severity_text",
             internal_name="sentry.severity_text",

tests/sentry/search/eap/test_ourlogs.py

@@ -180,7 +180,7 @@ def test_query_with_or(self):
 
     def test_query_with_or_and_brackets(self):
         where, having, _ = self.resolver.resolve_query(
-            "(message:123 and severity_text:345) or (message:foo and severity_text:bar)"
+            "(message:123 and severity_text:345) or (message:foo and severity:bar)"
         )
         assert where == TraceItemFilter(
             or_filter=OrFilter(

tests/snuba/api/endpoints/test_organization_trace_item_attributes.py

@@ -78,7 +78,7 @@ def test_substring_matching_logs(self):
         assert "test.attribute3" in keys
         assert "another.attribute" in keys
         assert "different.attr" in keys
-        assert "severity_text" in keys
+        assert "severity" in keys
 
         # With a prefix only match the attributes that start with "tes"
         response = self.do_request(query={"substring_match": "tes"})
@@ -111,7 +111,7 @@ def test_all_attributes(self):
         assert len(keys) >= 3
         assert "test.attribute1" in keys
         assert "test.attribute2" in keys
-        assert "severity_text" in keys
+        assert "severity" in keys
 
     def test_body_attribute(self):
         logs = [
@@ -129,7 +129,7 @@ def test_body_attribute(self):
 
         assert response.status_code == 200, response.content
         keys = {item["key"] for item in response.data}
-        assert keys == {"severity_text", "message", "project"}
+        assert keys == {"severity", "message", "project"}
 
     def test_disallowed_attributes(self):
         logs = [
@@ -149,7 +149,7 @@ def test_disallowed_attributes(self):
 
         assert response.status_code == 200, response.content
         keys = {item["key"] for item in response.data}
-        assert keys == {"severity_text", "message", "project", "sentry.item_type2"}
+        assert keys == {"severity", "message", "project", "sentry.item_type2"}
 
 
 class OrganizationTraceItemAttributeValuesEndpointTest(OrganizationEventsEndpointTestBase):

tests/snuba/api/endpoints/test_project_trace_item_details.py

@@ -105,7 +105,7 @@ def test_simple(self):
                 "value": str(timestamp_nanos),
             },
             {"name": "message", "type": "str", "value": "foo"},
-            {"name": "severity_text", "type": "str", "value": "INFO"},
+            {"name": "severity", "type": "str", "value": "INFO"},
             {"name": "str_attr", "type": "str", "value": "1"},
             {"name": "trace", "type": "str", "value": self.trace_uuid},
         ]
@@ -186,7 +186,7 @@ def test_simple_using_logs_item_type(self):
                     "value": str(timestamp_nanos),
                 },
                 {"name": "message", "type": "str", "value": "foo"},
-                {"name": "severity_text", "type": "str", "value": "INFO"},
+                {"name": "severity", "type": "str", "value": "INFO"},
                 {"name": "str_attr", "type": "str", "value": "1"},
                 {"name": "trace", "type": "str", "value": self.trace_uuid},
             ],