Skip to content

Commit 2d7dc89

Browse files
authored
test(ui): Switch acceptance tests to rspack (#91947)
run acceptance tests against a build created by rspack
1 parent 0157ee2 commit 2d7dc89

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/acceptance.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
8585
with:
8686
path: ${{ steps.config.outputs.webpack-path }}
87-
key: ${{ runner.os }}-v2-webpack-cache-${{ hashFiles('webpack.config.ts') }}
87+
key: ${{ runner.os }}-v2-webpack-cache-${{ hashFiles('rspack.config.ts', 'yarn.lock', 'package.json') }}
8888

8989
- name: node_modules cache
9090
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,8 @@
267267
"deref-api-docs": "ts-node api-docs/index.ts tests/apidocs/openapi-spectacular.json tests/apidocs/openapi-derefed.json",
268268
"build-chartcuterie-config": "node --experimental-strip-types config/build-chartcuterie.ts",
269269
"build-acceptance-rspack": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production rspack",
270-
"build-acceptance": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production webpack",
270+
"build-acceptance-webpack": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production webpack",
271+
"build-acceptance": "yarn build-acceptance-rspack",
271272
"build-production": "NODE_ENV=production webpack --mode production",
272273
"build-production-rspack": "NODE_ENV=production rspack --mode production",
273274
"build": "NODE_OPTIONS=--max-old-space-size=4096 webpack",

rspack.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ if (env.WEBPACK_CACHE_PATH) {
768768
// https://rspack.dev/config/experiments#cachestorage
769769
storage: {
770770
type: 'filesystem',
771-
directory: env.WEBPACK_CACHE_PATH,
771+
directory: path.join(__dirname, env.WEBPACK_CACHE_PATH),
772772
},
773773
};
774774
}

0 commit comments

Comments
 (0)