Raise an error rather than relying on Snuba telling us

Author: armenzg

src/sentry/search/events/builder/discover.py

@@ -74,6 +74,7 @@
 from sentry.utils.dates import outside_retention_with_modified_start
 from sentry.utils.snuba import (
     QueryOutsideRetentionError,
+    UnqualifiedQueryError,
     is_duration_measurement,
     is_measurement,
     is_numeric_measurement,
@@ -583,17 +584,17 @@ def resolve_params(self) -> list[WhereType]:
         if self.end:
             conditions.append(Condition(self.column("timestamp"), Op.LT, self.end))
 
-        # The clause will prevent calling Snuba with an empty list of projects, thus, returning
-        # no data. It will not instead complain with:
-        # sentry.utils.snuba.UnqualifiedQueryError: validation failed for entity events: missing required conditions for project_id
-        if self.params.project_ids:
-            conditions.append(
-                Condition(
-                    self.column("project_id"),
-                    Op.IN,
-                    self.params.project_ids,
-                )
+        # This will prevent calling Snuba with an empty list of projects, thus, returning no data.
+        if not self.params.project_ids:
+            raise UnqualifiedQueryError("You need to specify at least one project.")
+
+        conditions.append(
+            Condition(
+                self.column("project_id"),
+                Op.IN,
+                self.params.project_ids,
             )
+        )
 
         if len(self.params.environments) > 0:
             term = event_search.SearchFilter(

tests/sentry/search/events/builder/test_discover.py

@@ -68,7 +68,7 @@ def test_simple_query(self):
         )
         query.get_snql_query().validate()
 
-    def test_query_without_project_ids(self):
+    def test_project_ids_missing(self):
         params: ParamsType = {
             "start": self.params["start"],
             "end": self.params["end"],
@@ -78,7 +78,7 @@ def test_query_without_project_ids(self):
             query = QueryBuilder(Dataset.Discover, params, query="foo", selected_columns=["id"])
             bulk_snuba_queries([query.get_snql_query()], referrer=Referrer.TESTING_TEST.value)
 
-    def test_query_with_empty_project_ids(self):
+    def test_project_ids_with_empty_list(self):
         params: ParamsType = {
             "start": self.params["start"],
             "end": self.params["end"],