Skip to content

Commit 2f4890e

Browse files
getsentry-botk-fish
andcommitted
Revert "chore(ourlogs): Use the renderer for the template field too (#89629)"
This reverts commit 1550223. Co-authored-by: k-fish <6111995+k-fish@users.noreply.github.com>
1 parent 09b4b3e commit 2f4890e

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

static/app/views/explore/logs/fieldRenderers.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export function TraceIDRenderer(props: LogFieldRendererProps) {
135135
return <Link to={target}>{props.basicRendered}</Link>;
136136
}
137137

138-
export function LogBodyAndTemplateRenderer(props: LogFieldRendererProps) {
138+
export function LogBodyRenderer(props: LogFieldRendererProps) {
139139
const attribute_value = props.item.value as string;
140140
const highlightTerm = props.extra?.highlightTerms[0] ?? '';
141141
// TODO: Allow more than one highlight term to be highlighted at once.
@@ -194,8 +194,7 @@ export const LogAttributesRendererMap: Record<
194194
return TimestampRenderer(props);
195195
},
196196
[OurLogKnownFieldKey.SEVERITY_TEXT]: SeverityTextRenderer,
197-
[OurLogKnownFieldKey.MESSAGE]: LogBodyAndTemplateRenderer,
198-
[OurLogKnownFieldKey.TEMPLATE]: LogBodyAndTemplateRenderer,
197+
[OurLogKnownFieldKey.MESSAGE]: LogBodyRenderer,
199198
[OurLogKnownFieldKey.TRACE_ID]: TraceIDRenderer,
200199
};
201200

static/app/views/explore/logs/logsTableRow.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import {
2424
import {HiddenLogDetailFields} from 'sentry/views/explore/logs/constants';
2525
import {
2626
LogAttributesRendererMap,
27-
LogBodyAndTemplateRenderer,
27+
LogBodyRenderer,
2828
LogFieldRenderer,
2929
SeverityCircleRenderer,
3030
} from 'sentry/views/explore/logs/fieldRenderers';
@@ -259,7 +259,7 @@ function LogRowDetails({
259259
<Fragment>
260260
<DetailsContent>
261261
<DetailsBody>
262-
{LogBodyAndTemplateRenderer({
262+
{LogBodyRenderer({
263263
item: getLogRowItem(OurLogKnownFieldKey.MESSAGE, dataRow, meta),
264264
extra: {
265265
highlightTerms,

static/app/views/explore/logs/types.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ export enum OurLogKnownFieldKey {
1616
// From the EAP dataset directly not using a column alias.
1717
ID = 'sentry.item_id',
1818
MESSAGE = 'message',
19-
TEMPLATE = 'sentry.message.template',
2019
SEVERITY_NUMBER = 'severity_number',
2120
SEVERITY_TEXT = 'severity_text',
2221
ORGANIZATION_ID = 'organization.id',

0 commit comments

Comments
 (0)