Skip to content

Commit 32d999a

Browse files
ref: have AlertRule.detection_type code match schema width (#91898)
the migration which added this column added it as varchar(32) but this was not reflected in code until now -- fix it with a state-only migration <!-- Describe your PR here. -->
1 parent 0f4d578 commit 32d999a

File tree

3 files changed

+39
-1
lines changed

3 files changed

+39
-1
lines changed

migrations_lockfile.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ remote_subscriptions: 0003_drop_remote_subscription
2121

2222
replays: 0005_drop_replay_index
2323

24-
sentry: 0901_org_slug_wrong_index_name
24+
sentry: 0902_detection_type_match_size
2525

2626
social_auth: 0002_default_auto_field
2727

src/sentry/incidents/models/alert_rule.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ class AlertRule(Model):
220220
)
221221
description = models.CharField(max_length=1000, null=True)
222222
detection_type = models.CharField(
223+
max_length=32,
223224
default=AlertRuleDetectionType.STATIC,
224225
db_default=AlertRuleDetectionType.STATIC,
225226
choices=AlertRuleDetectionType.choices,
Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# Generated by Django 5.2.1 on 2025-05-19 20:54
2+
3+
from django.db import migrations, models
4+
5+
from sentry.new_migrations.migrations import CheckedMigration
6+
7+
8+
class Migration(CheckedMigration):
9+
# This flag is used to mark that a migration shouldn't be automatically run in production.
10+
# This should only be used for operations where it's safe to run the migration after your
11+
# code has deployed. So this should not be used for most operations that alter the schema
12+
# of a table.
13+
# Here are some things that make sense to mark as post deployment:
14+
# - Large data migrations. Typically we want these to be run manually so that they can be
15+
# monitored and not block the deploy for a long period of time while they run.
16+
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
17+
# run this outside deployments so that we don't block them. Note that while adding an index
18+
# is a schema change, it's completely safe to run the operation after the code has deployed.
19+
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
20+
21+
is_post_deployment = False
22+
23+
dependencies = [
24+
("sentry", "0901_org_slug_wrong_index_name"),
25+
]
26+
27+
operations = [
28+
migrations.SeparateDatabaseAndState(
29+
state_operations=[
30+
migrations.AlterField(
31+
model_name="alertrule",
32+
name="detection_type",
33+
field=models.CharField(db_default="static", default="static", max_length=32),
34+
),
35+
]
36+
),
37+
]

0 commit comments

Comments
 (0)