chore(perf-issues): Remove GA'd/unusued project admin settings (#92116)

Also refactors some of the Internal <-> Configurable settings for
performance detectors since the toggling is user facing now.

Author: leeandher

src/sentry/api/endpoints/project_details.py

@@ -128,9 +128,6 @@ class ProjectMemberSerializer(serializers.Serializer):
         "copy_from_project",
         "targetSampleRate",
         "dynamicSamplingBiases",
-        "performanceIssueCreationRate",
-        "performanceIssueCreationThroughPlatform",
-        "performanceIssueSendToPlatform",
         "tempestFetchScreenshots",
         "tempestFetchDumps",
         "autofixAutomationTuning",
@@ -223,9 +220,6 @@ class ProjectAdminSerializer(ProjectMemberSerializer):
     copy_from_project = serializers.IntegerField(required=False)
     targetSampleRate = serializers.FloatField(required=False, min_value=0, max_value=1)
     dynamicSamplingBiases = DynamicSamplingBiasSerializer(required=False, many=True)
-    performanceIssueCreationRate = serializers.FloatField(required=False, min_value=0, max_value=1)
-    performanceIssueCreationThroughPlatform = serializers.BooleanField(required=False)
-    performanceIssueSendToPlatform = serializers.BooleanField(required=False)
     tempestFetchScreenshots = serializers.BooleanField(required=False)
     tempestFetchDumps = serializers.BooleanField(required=False)
     autofixAutomationTuning = serializers.ChoiceField(

src/sentry/api/endpoints/project_performance_issue_settings.py

@@ -34,72 +34,84 @@
 SETTINGS_PROJECT_OPTION_KEY = "sentry:performance_issue_settings"
 
 
-# These options should only be accessible internally and used by
-# support to enable/disable performance issue detection for an outlying project
-# on a case-by-case basis.
 class InternalProjectOptions(Enum):
-    N_PLUS_ONE_DB = "n_plus_one_db_queries_detection_enabled"
-    UNCOMPRESSED_ASSET = "uncompressed_assets_detection_enabled"
-    CONSECUTIVE_HTTP_SPANS = "consecutive_http_spans_detection_enabled"
-    LARGE_HTTP_PAYLOAD = "large_http_payload_detection_enabled"
-    N_PLUS_ONE_API_CALLS = "n_plus_one_api_calls_detection_enabled"
-    DB_ON_MAIN_THREAD = "db_on_main_thread_detection_enabled"
-    FILE_IO_MAIN_THREAD = "file_io_on_main_thread_detection_enabled"
-    CONSECUTIVE_DB_QUERIES = "consecutive_db_queries_detection_enabled"
-    RENDER_BLOCKING_ASSET = "large_render_blocking_asset_detection_enabled"
-    SLOW_DB_QUERY = "slow_db_queries_detection_enabled"
-    HTTP_OVERHEAD = "http_overhead_detection_enabled"
+    """
+    Settings that are only accessible to superusers.
+    """
+
     TRANSACTION_DURATION_REGRESSION = "transaction_duration_regression_detection_enabled"
     FUNCTION_DURATION_REGRESSION = "function_duration_regression_detection_enabled"
 
 
 class ConfigurableThresholds(Enum):
+    """
+    All the settings that can be configured by users with the appropriate permissions.
+    """
+
+    N_PLUS_ONE_DB = "n_plus_one_db_queries_detection_enabled"
     N_PLUS_ONE_DB_DURATION = "n_plus_one_db_duration_threshold"
     N_PLUS_ONE_DB_COUNT = "n_plus_one_db_count"
+    UNCOMPRESSED_ASSET = "uncompressed_assets_detection_enabled"
     UNCOMPRESSED_ASSET_DURATION = "uncompressed_asset_duration_threshold"
     UNCOMPRESSED_ASSET_SIZE = "uncompressed_asset_size_threshold"
+    LARGE_HTTP_PAYLOAD = "large_http_payload_detection_enabled"
     LARGE_HTTP_PAYLOAD_SIZE = "large_http_payload_size_threshold"
+    DB_ON_MAIN_THREAD = "db_on_main_thread_detection_enabled"
     DB_ON_MAIN_THREAD_DURATION = "db_on_main_thread_duration_threshold"
+    FILE_IO_MAIN_THREAD = "file_io_on_main_thread_detection_enabled"
     FILE_IO_MAIN_THREAD_DURATION = "file_io_on_main_thread_duration_threshold"
+    CONSECUTIVE_DB_QUERIES = "consecutive_db_queries_detection_enabled"
     CONSECUTIVE_DB_QUERIES_MIN_TIME_SAVED = "consecutive_db_min_time_saved_threshold"
+    RENDER_BLOCKING_ASSET = "large_render_blocking_asset_detection_enabled"
     RENDER_BLOCKING_ASSET_FCP_RATIO = "render_blocking_fcp_ratio"
+    SLOW_DB_QUERY = "slow_db_queries_detection_enabled"
     SLOW_DB_QUERY_DURATION = "slow_db_query_duration_threshold"
+    N_PLUS_ONE_API_CALLS = "n_plus_one_api_calls_detection_enabled"
     N_PLUS_API_CALLS_DURATION = "n_plus_one_api_calls_total_duration_threshold"
+    CONSECUTIVE_HTTP_SPANS = "consecutive_http_spans_detection_enabled"
     CONSECUTIVE_HTTP_SPANS_MIN_TIME_SAVED = "consecutive_http_spans_min_time_saved_threshold"
+    HTTP_OVERHEAD = "http_overhead_detection_enabled"
     HTTP_OVERHEAD_REQUEST_DELAY = "http_request_delay_threshold"
 
 
-internal_only_project_settings_to_group_map: dict[str, type[GroupType]] = {
-    InternalProjectOptions.UNCOMPRESSED_ASSET.value: PerformanceUncompressedAssetsGroupType,
-    InternalProjectOptions.CONSECUTIVE_HTTP_SPANS.value: PerformanceConsecutiveHTTPQueriesGroupType,
-    InternalProjectOptions.LARGE_HTTP_PAYLOAD.value: PerformanceLargeHTTPPayloadGroupType,
-    InternalProjectOptions.N_PLUS_ONE_DB.value: PerformanceNPlusOneGroupType,
-    InternalProjectOptions.N_PLUS_ONE_API_CALLS.value: PerformanceNPlusOneAPICallsGroupType,
-    InternalProjectOptions.DB_ON_MAIN_THREAD.value: PerformanceDBMainThreadGroupType,
-    InternalProjectOptions.FILE_IO_MAIN_THREAD.value: PerformanceFileIOMainThreadGroupType,
-    InternalProjectOptions.CONSECUTIVE_DB_QUERIES.value: PerformanceConsecutiveDBQueriesGroupType,
-    InternalProjectOptions.RENDER_BLOCKING_ASSET.value: PerformanceRenderBlockingAssetSpanGroupType,
-    InternalProjectOptions.SLOW_DB_QUERY.value: PerformanceSlowDBQueryGroupType,
-    InternalProjectOptions.HTTP_OVERHEAD.value: PerformanceHTTPOverheadGroupType,
+project_settings_to_group_map: dict[str, type[GroupType]] = {
+    ConfigurableThresholds.UNCOMPRESSED_ASSET.value: PerformanceUncompressedAssetsGroupType,
+    ConfigurableThresholds.CONSECUTIVE_HTTP_SPANS.value: PerformanceConsecutiveHTTPQueriesGroupType,
+    ConfigurableThresholds.LARGE_HTTP_PAYLOAD.value: PerformanceLargeHTTPPayloadGroupType,
+    ConfigurableThresholds.N_PLUS_ONE_DB.value: PerformanceNPlusOneGroupType,
+    ConfigurableThresholds.N_PLUS_ONE_API_CALLS.value: PerformanceNPlusOneAPICallsGroupType,
+    ConfigurableThresholds.DB_ON_MAIN_THREAD.value: PerformanceDBMainThreadGroupType,
+    ConfigurableThresholds.FILE_IO_MAIN_THREAD.value: PerformanceFileIOMainThreadGroupType,
+    ConfigurableThresholds.CONSECUTIVE_DB_QUERIES.value: PerformanceConsecutiveDBQueriesGroupType,
+    ConfigurableThresholds.RENDER_BLOCKING_ASSET.value: PerformanceRenderBlockingAssetSpanGroupType,
+    ConfigurableThresholds.SLOW_DB_QUERY.value: PerformanceSlowDBQueryGroupType,
+    ConfigurableThresholds.HTTP_OVERHEAD.value: PerformanceHTTPOverheadGroupType,
     InternalProjectOptions.TRANSACTION_DURATION_REGRESSION.value: PerformanceP95EndpointRegressionGroupType,
     InternalProjectOptions.FUNCTION_DURATION_REGRESSION.value: ProfileFunctionRegressionType,
 }
-
-configurable_thresholds_to_internal_settings_map: dict[str, str] = {
-    ConfigurableThresholds.N_PLUS_ONE_DB_DURATION.value: InternalProjectOptions.N_PLUS_ONE_DB.value,
-    ConfigurableThresholds.N_PLUS_ONE_DB_COUNT.value: InternalProjectOptions.N_PLUS_ONE_DB.value,
-    ConfigurableThresholds.UNCOMPRESSED_ASSET_DURATION.value: InternalProjectOptions.UNCOMPRESSED_ASSET.value,
-    ConfigurableThresholds.UNCOMPRESSED_ASSET_SIZE.value: InternalProjectOptions.UNCOMPRESSED_ASSET.value,
-    ConfigurableThresholds.LARGE_HTTP_PAYLOAD_SIZE.value: InternalProjectOptions.LARGE_HTTP_PAYLOAD.value,
-    ConfigurableThresholds.DB_ON_MAIN_THREAD_DURATION.value: InternalProjectOptions.DB_ON_MAIN_THREAD.value,
-    ConfigurableThresholds.FILE_IO_MAIN_THREAD_DURATION.value: InternalProjectOptions.FILE_IO_MAIN_THREAD.value,
-    ConfigurableThresholds.CONSECUTIVE_DB_QUERIES_MIN_TIME_SAVED.value: InternalProjectOptions.CONSECUTIVE_DB_QUERIES.value,
-    ConfigurableThresholds.RENDER_BLOCKING_ASSET_FCP_RATIO.value: InternalProjectOptions.RENDER_BLOCKING_ASSET.value,
-    ConfigurableThresholds.SLOW_DB_QUERY_DURATION.value: InternalProjectOptions.SLOW_DB_QUERY.value,
-    ConfigurableThresholds.N_PLUS_API_CALLS_DURATION.value: InternalProjectOptions.N_PLUS_ONE_API_CALLS.value,
-    ConfigurableThresholds.CONSECUTIVE_HTTP_SPANS_MIN_TIME_SAVED.value: InternalProjectOptions.CONSECUTIVE_HTTP_SPANS.value,
-    ConfigurableThresholds.HTTP_OVERHEAD_REQUEST_DELAY.value: InternalProjectOptions.HTTP_OVERHEAD.value,
+"""
+A mapping of the management settings to the group type that the detector spawns.
+"""
+
+thresholds_to_manage_map: dict[str, str] = {
+    ConfigurableThresholds.N_PLUS_ONE_DB_DURATION.value: ConfigurableThresholds.N_PLUS_ONE_DB.value,
+    ConfigurableThresholds.N_PLUS_ONE_DB_COUNT.value: ConfigurableThresholds.N_PLUS_ONE_DB.value,
+    ConfigurableThresholds.UNCOMPRESSED_ASSET_DURATION.value: ConfigurableThresholds.UNCOMPRESSED_ASSET.value,
+    ConfigurableThresholds.UNCOMPRESSED_ASSET_SIZE.value: ConfigurableThresholds.UNCOMPRESSED_ASSET.value,
+    ConfigurableThresholds.LARGE_HTTP_PAYLOAD_SIZE.value: ConfigurableThresholds.LARGE_HTTP_PAYLOAD.value,
+    ConfigurableThresholds.DB_ON_MAIN_THREAD_DURATION.value: ConfigurableThresholds.DB_ON_MAIN_THREAD.value,
+    ConfigurableThresholds.FILE_IO_MAIN_THREAD_DURATION.value: ConfigurableThresholds.FILE_IO_MAIN_THREAD.value,
+    ConfigurableThresholds.CONSECUTIVE_DB_QUERIES_MIN_TIME_SAVED.value: ConfigurableThresholds.CONSECUTIVE_DB_QUERIES.value,
+    ConfigurableThresholds.RENDER_BLOCKING_ASSET_FCP_RATIO.value: ConfigurableThresholds.RENDER_BLOCKING_ASSET.value,
+    ConfigurableThresholds.SLOW_DB_QUERY_DURATION.value: ConfigurableThresholds.SLOW_DB_QUERY.value,
+    ConfigurableThresholds.N_PLUS_API_CALLS_DURATION.value: ConfigurableThresholds.N_PLUS_ONE_API_CALLS.value,
+    ConfigurableThresholds.CONSECUTIVE_HTTP_SPANS_MIN_TIME_SAVED.value: ConfigurableThresholds.CONSECUTIVE_HTTP_SPANS.value,
+    ConfigurableThresholds.HTTP_OVERHEAD_REQUEST_DELAY.value: ConfigurableThresholds.HTTP_OVERHEAD.value,
 }
+"""
+A mapping of threshold setting to the parent setting that manages it's detection.
+Used to determine if a threshold setting can be modified.
+"""
 
 
 class ProjectPerformanceIssueSettingsSerializer(serializers.Serializer):
@@ -155,15 +167,26 @@ class ProjectPerformanceIssueSettingsSerializer(serializers.Serializer):
     function_duration_regression_detection_enabled = serializers.BooleanField(required=False)
 
 
+def get_management_options() -> list[str]:
+    """
+    Returns the option keys that control whether a performance issue detector is enabled.
+    """
+    return [
+        *[setting.value for setting in InternalProjectOptions],
+        *list(thresholds_to_manage_map.values()),
+    ]
+
+
 def get_disabled_threshold_options(payload, current_settings):
+    """
+    Returns the option keys that are disabled, based on the current management settings.
+    """
     options = []
-    internal_only_settings = [setting.value for setting in InternalProjectOptions]
+    management_options = get_management_options()
     for option in payload:
-        if option not in internal_only_settings:
-            internal_setting_for_option = configurable_thresholds_to_internal_settings_map.get(
-                option
-            )
-            is_threshold_enabled = current_settings.get(internal_setting_for_option)
+        if option not in management_options:
+            manage_detector_setting = thresholds_to_manage_map.get(option)
+            is_threshold_enabled = current_settings.get(manage_detector_setting)
             if not is_threshold_enabled:
                 options.append(option)
     return options
@@ -222,15 +245,7 @@ def put(self, request: Request, project) -> Response:
             )
 
         body_has_admin_options = any([option in request.data for option in internal_only_settings])
-        if (
-            body_has_admin_options
-            and not superuser_has_permission(request)
-            and not features.has(
-                "organizations:performance-manage-detectors",
-                project.organization,
-                actor=request.user,
-            )
-        ):
+        if body_has_admin_options and not superuser_has_permission(request):
             return Response(
                 {
                     "detail": {
@@ -241,6 +256,9 @@ def put(self, request: Request, project) -> Response:
                 status=status.HTTP_403_FORBIDDEN,
             )
 
+        body_has_management_options = any(
+            [option in get_management_options() for option in request.data]
+        )
         serializer = ProjectPerformanceIssueSettingsSerializer(data=request.data)
 
         if not serializer.is_valid():
@@ -273,7 +291,7 @@ def put(self, request: Request, project) -> Response:
             {**performance_issue_settings_default, **performance_issue_settings, **data},
         )
 
-        if body_has_admin_options:
+        if body_has_admin_options or body_has_management_options:
             self.create_audit_entry(
                 request=self.request,
                 actor=request.user,
@@ -290,16 +308,16 @@ def delete(self, request: Request, project) -> Response:
             return self.respond(status=status.HTTP_404_NOT_FOUND)
 
         project_settings = project.get_option(SETTINGS_PROJECT_OPTION_KEY, default={})
+        management_options = get_management_options()
         threshold_options = [setting.value for setting in ConfigurableThresholds]
-        internal_only_settings = [setting.value for setting in InternalProjectOptions]
         disabled_options = get_disabled_threshold_options(threshold_options, project_settings)
 
         if project_settings:
             unchanged_options = (
-                {  # internal settings and disabled threshold settings can not be reset
+                {  # Management settings and disabled threshold settings can not be reset
                     option: project_settings[option]
                     for option in project_settings
-                    if option in internal_only_settings or option in disabled_options
+                    if option in management_options or option in disabled_options
                 }
             )
             project.update_option(SETTINGS_PROJECT_OPTION_KEY, unchanged_options)

src/sentry/audit_log/events.py

@@ -181,7 +181,7 @@ def __init__(self):
 
     def render(self, audit_log_entry: AuditLogEntry):
         from sentry.api.endpoints.project_performance_issue_settings import (
-            internal_only_project_settings_to_group_map as map,
+            project_settings_to_group_map as map,
         )
 
         data = audit_log_entry.data

src/sentry/utils/performance_issues/README.md

@@ -52,7 +52,7 @@ There are quite a few places which need to be updated when adding a new performa
   - [ ] If your value is not customizable, add it to the dictionary
   - [ ] If it is customizable, access it via `settings[key_name]`
     - [ ] Then add it to [project_performance_issue_settings.py](../../api/endpoints/project_performance_issue_settings.py), either `InternalProjectOptions` or `ConfigurableThresholds`
-    - [ ] In the same file, Add it to the map, either `internal_only_project_settings_to_group_map` or `configurable_thresholds_to_internal_settings_map` using the new GroupType
+    - [ ] In the same file, Add it to the mappings `project_settings_to_group_map`/`thresholds_to_manage_map` using the new GroupType
     - [ ] In the same file, Add a serializer field to `ProjectPerformanceIssueSettingsSerializer` to allow it to be validated from the inbound API.
     - [ ] (Optional) The frontend file (`projectPerformance.tsx`) should add the new field.
     - [ ] Then, to set a default value, register an option in [defaults.py](../../options/defaults.py)

tests/sentry/api/endpoints/test_project_performance_issue_settings.py

@@ -149,7 +149,7 @@ def test_put_non_super_user_updates_detection_setting(self):
         response = self.get_error_response(
             self.project.organization.slug,
             self.project.slug,
-            n_plus_one_db_queries_detection_enabled=False,
+            transaction_duration_regression_detection_enabled=False,
             method="put",
             status_code=status.HTTP_403_FORBIDDEN,
         )
@@ -187,7 +187,7 @@ def test_put_superuser_read_write_updates_detection_setting(self):
         self.get_error_response(
             self.project.organization.slug,
             self.project.slug,
-            n_plus_one_db_queries_detection_enabled=False,
+            function_duration_regression_detection_enabled=False,
             method="put",
             status_code=status.HTTP_403_FORBIDDEN,
         )
@@ -198,18 +198,18 @@ def test_put_superuser_read_write_updates_detection_setting(self):
         response = self.get_success_response(
             self.project.organization.slug,
             self.project.slug,
-            n_plus_one_db_queries_detection_enabled=False,
+            function_duration_regression_detection_enabled=False,
             method="put",
             status_code=status.HTTP_200_OK,
         )
 
-        assert not response.data["n_plus_one_db_queries_detection_enabled"]
+        assert not response.data["function_duration_regression_detection_enabled"]
 
         get_response = self.get_success_response(
             self.project.organization.slug, self.project.slug, format="json"
         )
 
-        assert not get_response.data["n_plus_one_db_queries_detection_enabled"]
+        assert not get_response.data["function_duration_regression_detection_enabled"]
 
     @with_feature("organizations:performance-view")
     def test_put_update_non_super_user_option(self):