chore(typescript): Switch to --moduleResolution bundler, remove duplicate properties, remove @ts-expect-error comments (#91686)

Related to #90413.

In order to cleanly measure relative performance improvements in [the
native port of the TypeScript
compiler](https://github.com/microsoft/typescript-go), this change
removes some errors found by compiling with tsgo. Specifically:

- duplicate computed-name properties have been removed
- unnecessary `@ts-expect-error` comments have been removed (thanks to
new `moduleResolution` settings`)
- deep imports into `@emotion/styled` have been replaced by updating an
existing top-level import
- module resolution has been updated to `bundler` because
- `--moduleResolution node` a.k.a. `node10` will be deprecated in
TypeScript 6.0
- `--moduleResolution nodenext` will not work because many existing
paths in `import()` calls lack a file extension
- in reality, most files are processed by a bundler down the line (or a
runtime like ts-node that has bundler-like resolution mechanics)

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---------

Co-authored-by: Scott Cooper <scttcper@gmail.com>

Author: 2 people

config/build-chartcuterie.ts

@@ -6,7 +6,6 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import {fileURLToPath} from 'node:url';
 
-// @ts-expect-error need to switch tsconfig to use module: esnext or es2020
 const scriptDir = path.dirname(fileURLToPath(import.meta.url));
 const workspaceRoot = path.resolve(scriptDir, '..');
 const packageJsonPath = path.join(workspaceRoot, 'package.json');

config/tsconfig.base.json

@@ -14,9 +14,9 @@
     //
     // [0]: https://babeljs.io/docs/en/babel-preset-typescript
     // [1]: https://node.green
-    "module": "commonjs",
+    "module": "preserve",
     "target": "ES2022",
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
 
     // We add esnext to lib to pull in types for all newer ECMAScript features
     "lib": ["esnext", "dom", "dom.iterable"],
@@ -124,6 +124,13 @@
   "include": ["../static/app", "../static/gsApp", "../tests/js"],
   "exclude": ["../node_modules", "../**/*.benchmark.ts"],
   "ts-node": {
-    "transpileOnly": true
+    "transpileOnly": true,
+    "compilerOptions": {
+      // TODO: We should be able to use "node16" on next major version of jest
+      // https://github.com/jestjs/jest/pull/14739
+      "module": "commonjs",
+      // TODO: node10 will be deprecated in typescript 6.0
+      "moduleResolution": "node10"
+    }
   }
 }

eslint.config.mjs

@@ -169,7 +169,6 @@ export default typescript.config([
         // https://typescript-eslint.io/packages/parser/#projectservice
         // `projectService` is recommended, but slower, with our current tsconfig files.
         projectService: true,
-        // @ts-expect-error TS1343: The import.meta meta-property is only allowed when the --module option is es2020, es2022, esnext, system, node16, or nodenext
         tsconfigRootDir: import.meta.dirname,
       },
     },

static/app/utils/theme/theme.chonk.tsx

@@ -3,8 +3,8 @@ import {type Theme, useTheme} from '@emotion/react';
 import styled, {
   type CreateStyledComponent,
   type FilteringStyledOptions,
+  type StyledOptions,
 } from '@emotion/styled';
-import type {StyledOptions} from '@emotion/styled/dist/declarations/src/types';
 import color from 'color';
 
 import type {ColorMapping, FormTheme, Theme as SentryTheme} from './theme';

static/app/views/insights/browser/resources/utils/useResourceFilters.ts

@@ -25,7 +25,6 @@ export type ModuleFilters = {
   [BrowserStarfishFields.SPAN_DOMAIN]?: string;
   [BrowserStarfishFields.SPAN_OP]?: ResourceSpanOps;
   [BrowserStarfishFields.TRANSACTION]?: string;
-  [BrowserStarfishFields.SPAN_DOMAIN]?: string;
   [BrowserStarfishFields.USER_GEO_SUBREGION]?: SubregionCode[];
 };
 

static/app/views/insights/types.tsx

@@ -428,7 +428,6 @@ export type SpanIndexedResponse = {
     | 'unavailable'
     | 'data_loss'
     | 'unauthenticated';
-  [SpanIndexedField.SPAN_ID]: string;
   [SpanIndexedField.SPAN_ACTION]: string;
   [SpanIndexedField.TRACE]: string;
   [SpanIndexedField.TRANSACTION]: string;
@@ -488,8 +487,6 @@ export type SpanIndexedResponse = {
   [SpanIndexedField.LCP_ELEMENT]: string;
   [SpanIndexedField.CLS_SOURCE]: string;
   [SpanIndexedField.MEASUREMENT_HTTP_RESPONSE_CONTENT_LENGTH]: number;
-  [SpanIndexedField.PROJECT]: string;
-  [SpanIndexedField.SPAN_GROUP]: string;
   'any(id)': string;
   [SpanIndexedField.DB_SYSTEM]: SupportedDatabaseSystem;
   [SpanIndexedField.CODE_FILEPATH]: string;