@@ -601,19 +601,6 @@ def test_splits_rules_correctly(self):
601
601
"function:kangaroo -group" , # Split of `function:kangaroo -app -group`
602
602
]
603
603
604
- def test_obeys_version_for_splitting_choice (self ):
605
- enhancements = Enhancements .from_rules_text (self .rules_text )
606
- assert enhancements .classifier_rules == []
607
- assert enhancements .contributes_rules == []
608
-
609
- enhancements = Enhancements .from_rules_text (self .rules_text , version = 2 )
610
- assert enhancements .classifier_rules == []
611
- assert enhancements .contributes_rules == []
612
-
613
- enhancements = Enhancements .from_rules_text (self .rules_text , version = 3 )
614
- assert len (enhancements .classifier_rules ) > 0
615
- assert len (enhancements .contributes_rules ) > 0
616
-
617
604
def test_adds_split_rules_to_base_enhancements (self ):
618
605
for base in ENHANCEMENT_BASES .values ():
619
606
# Make these sets so checking in them is faster
@@ -884,7 +871,9 @@ def test_marks_app_stacktrace_non_contributing_if_no_in_app_frames(self):
884
871
# In this case, even after we force the system frame not to contribute, we'll still have
885
872
# another contributing frame, so we'll use rust's `contributing: True` for the stacktrace
886
873
# component.
887
- with mock .patch .object (enhancements1 , "rust_enhancements" , mock_rust_enhancements1 ):
874
+ with mock .patch .object (
875
+ enhancements1 , "contributes_rust_enhancements" , mock_rust_enhancements1
876
+ ):
888
877
stacktrace_component1 = enhancements1 .assemble_stacktrace_component (
889
878
variant_name = "app" ,
890
879
frame_components = frame_components ,
@@ -902,7 +891,9 @@ def test_marks_app_stacktrace_non_contributing_if_no_in_app_frames(self):
902
891
903
892
# In this case, once we force the system frame not to contribute, we won't have any
904
893
# contributing frames, so we'll force `contributing: False` for the stacktrace component.
905
- with mock .patch .object (enhancements2 , "rust_enhancements" , mock_rust_enhancements2 ):
894
+ with mock .patch .object (
895
+ enhancements2 , "contributes_rust_enhancements" , mock_rust_enhancements2
896
+ ):
906
897
stacktrace_component2 = enhancements2 .assemble_stacktrace_component (
907
898
variant_name = "app" ,
908
899
frame_components = frame_components ,
0 commit comments