Skip to content

Commit 42f32bc

Browse files
committed
fix tests
1 parent 81914a4 commit 42f32bc

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

tests/sentry/grouping/test_enhancer.py

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -601,19 +601,6 @@ def test_splits_rules_correctly(self):
601601
"function:kangaroo -group", # Split of `function:kangaroo -app -group`
602602
]
603603

604-
def test_obeys_version_for_splitting_choice(self):
605-
enhancements = Enhancements.from_rules_text(self.rules_text)
606-
assert enhancements.classifier_rules == []
607-
assert enhancements.contributes_rules == []
608-
609-
enhancements = Enhancements.from_rules_text(self.rules_text, version=2)
610-
assert enhancements.classifier_rules == []
611-
assert enhancements.contributes_rules == []
612-
613-
enhancements = Enhancements.from_rules_text(self.rules_text, version=3)
614-
assert len(enhancements.classifier_rules) > 0
615-
assert len(enhancements.contributes_rules) > 0
616-
617604
def test_adds_split_rules_to_base_enhancements(self):
618605
for base in ENHANCEMENT_BASES.values():
619606
# Make these sets so checking in them is faster
@@ -884,7 +871,9 @@ def test_marks_app_stacktrace_non_contributing_if_no_in_app_frames(self):
884871
# In this case, even after we force the system frame not to contribute, we'll still have
885872
# another contributing frame, so we'll use rust's `contributing: True` for the stacktrace
886873
# component.
887-
with mock.patch.object(enhancements1, "rust_enhancements", mock_rust_enhancements1):
874+
with mock.patch.object(
875+
enhancements1, "contributes_rust_enhancements", mock_rust_enhancements1
876+
):
888877
stacktrace_component1 = enhancements1.assemble_stacktrace_component(
889878
variant_name="app",
890879
frame_components=frame_components,
@@ -902,7 +891,9 @@ def test_marks_app_stacktrace_non_contributing_if_no_in_app_frames(self):
902891

903892
# In this case, once we force the system frame not to contribute, we won't have any
904893
# contributing frames, so we'll force `contributing: False` for the stacktrace component.
905-
with mock.patch.object(enhancements2, "rust_enhancements", mock_rust_enhancements2):
894+
with mock.patch.object(
895+
enhancements2, "contributes_rust_enhancements", mock_rust_enhancements2
896+
):
906897
stacktrace_component2 = enhancements2.assemble_stacktrace_component(
907898
variant_name="app",
908899
frame_components=frame_components,

0 commit comments

Comments
 (0)