ref: convert a few modules to non-django unit tests (#89381)

this makes almost zero difference in the overall testsuite -- but can
improve individual module performance when testing locally. since I did
the work I figure I might as well merge it but I'm going to not spend
any more time converting other ones 🤷

<!-- Describe your PR here. -->

Author: asottile-sentry

src/sentry/testutils/cases.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import hashlib
-import importlib.metadata
 import inspect
 import os.path
 import random
@@ -976,23 +975,6 @@ def setUp(self):
             plugins.register(self.plugin)
             self.addCleanup(plugins.unregister, self.plugin)
 
-    def assertAppInstalled(self, name, path):
-        for ep in importlib.metadata.distribution("sentry").entry_points:
-            if ep.group == "sentry.apps" and ep.name == name:
-                assert ep.value == path
-                return
-        else:
-            self.fail(f"Missing app from entry_points: {name!r}")
-
-    def assertPluginInstalled(self, name, plugin):
-        path = type(plugin).__module__ + ":" + type(plugin).__name__
-        for ep in importlib.metadata.distribution("sentry").entry_points:
-            if ep.group == "sentry.plugins" and ep.name == name:
-                assert ep.value == path
-                return
-        else:
-            self.fail(f"Missing plugin from entry_points: {name!r}")
-
 
 class CliTestCase(TestCase):
     @cached_property

src/sentry/testutils/helpers/plugins.py

@@ -0,0 +1,20 @@
+import importlib.metadata
+
+
+def _get_ep(group: str, name: str) -> importlib.metadata.EntryPoint | None:
+    for ep in importlib.metadata.distribution("sentry").entry_points:
+        if ep.group == group and ep.name == name:
+            return ep
+    else:
+        return None
+
+
+def assert_plugin_installed(name: str, plugin: object) -> None:
+    path = type(plugin).__module__ + ":" + type(plugin).__name__
+    ep = _get_ep("sentry.plugins", name)
+    assert ep is not None and ep.value == path
+
+
+def assert_app_installed(name: str, path: str) -> None:
+    ep = _get_ep("sentry.apps", name)
+    assert ep is not None and ep.value == path

tests/apidocs/test_hooks.py

@@ -1,5 +1,6 @@
+from unittest import TestCase
+
 from sentry.apidocs.hooks import custom_postprocessing_hook
-from sentry.testutils.cases import TestCase
 
 
 class FixIssueRoutesTest(TestCase):

tests/sentry/api/endpoints/release_thresholds/health_checks/test_is_crash_free_rate_healthy.py

@@ -18,14 +18,13 @@
 from .test_fixtures import mock_sessions_data
 
 
-class GetIntervalIndexesTest(TestCase):
-    def setUp(self):
+class TestGetIntervalIndexes:
+    def setup_method(self):
         # d.strftime('%Y-%m-%dT%H:%M:%SZ')
         # construct timestamps in iso utc format
         self.now = datetime.utcnow()
-        offsets = [r for r in range(-5, 5)]
         self.intervals = [
-            (self.now + timedelta(hours=x)).strftime("%Y-%m-%dT%H:%M:%SZ") for x in offsets
+            (self.now + timedelta(hours=x)).strftime("%Y-%m-%dT%H:%M:%SZ") for x in range(-5, 5)
         ]
 
     def test_gets_indexes_range_in_intervals(self):
@@ -59,14 +58,10 @@ def test_returns_bad_idxs_when_not_within_intervals(self):
         assert start_idx > end_idx
 
 
-class GetGroupTotals(TestCase):
-    def setUp(self):
-        # Mock data has 10 intervals
-        self.mock_sessions_data = mock_sessions_data
-
+class TestGetGroupTotals:
     def test_filters_groups_and_sums_total_success(self):
         total_v1 = get_groups_totals(
-            sessions_data=self.mock_sessions_data,
+            sessions_data=mock_sessions_data,
             release_version="version1",
             project_id=1,
             field="sum(session)",
@@ -76,7 +71,7 @@ def test_filters_groups_and_sums_total_success(self):
         assert total_v1 == 11
         # filters via release version
         total_v2 = get_groups_totals(
-            sessions_data=self.mock_sessions_data,
+            sessions_data=mock_sessions_data,
             release_version="version2",
             project_id=1,
             field="sum(session)",
@@ -87,7 +82,7 @@ def test_filters_groups_and_sums_total_success(self):
 
     def test_filters_group_by_project(self):
         total_p2_v1 = get_groups_totals(
-            sessions_data=self.mock_sessions_data,
+            sessions_data=mock_sessions_data,
             release_version="version1",
             project_id=2,
             field="sum(session)",
@@ -97,7 +92,7 @@ def test_filters_group_by_project(self):
         assert total_p2_v1 == 0
 
         total_p2_v2 = get_groups_totals(
-            sessions_data=self.mock_sessions_data,
+            sessions_data=mock_sessions_data,
             release_version="version2",
             project_id=2,
             field="sum(session)",
@@ -108,7 +103,7 @@ def test_filters_group_by_project(self):
 
     def test_filters_group_by_environment(self):
         total_canary = get_groups_totals(
-            sessions_data=self.mock_sessions_data,
+            sessions_data=mock_sessions_data,
             release_version="version1",
             project_id=1,
             field="sum(session)",
@@ -118,7 +113,7 @@ def test_filters_group_by_environment(self):
         )
         assert total_canary == 0
         total_production = get_groups_totals(
-            sessions_data=self.mock_sessions_data,
+            sessions_data=mock_sessions_data,
             release_version="version1",
             project_id=1,
             field="sum(session)",
@@ -130,7 +125,7 @@ def test_filters_group_by_environment(self):
 
     def test_filters_group_by_status(self):
         crashed = get_groups_totals(
-            sessions_data=self.mock_sessions_data,
+            sessions_data=mock_sessions_data,
             release_version="version1",
             project_id=1,
             field="sum(session)",
@@ -142,7 +137,7 @@ def test_filters_group_by_status(self):
 
     def test_sums_group_via_indexes(self):
         total_5_9 = get_groups_totals(
-            sessions_data=self.mock_sessions_data,
+            sessions_data=mock_sessions_data,
             release_version="version1",
             project_id=1,
             field="sum(session)",
@@ -154,7 +149,7 @@ def test_sums_group_via_indexes(self):
     def test_raises_errors_with_bad_indexes(self):
         with pytest.raises(IndexError):
             get_groups_totals(
-                sessions_data=self.mock_sessions_data,
+                sessions_data=mock_sessions_data,
                 release_version="version1",
                 project_id=1,
                 field="sum(session)",
@@ -164,7 +159,7 @@ def test_raises_errors_with_bad_indexes(self):
 
         with pytest.raises(IndexError):
             get_groups_totals(
-                sessions_data=self.mock_sessions_data,
+                sessions_data=mock_sessions_data,
                 release_version="version1",
                 project_id=1,
                 field="sum(session)",

tests/sentry/api/endpoints/test_index.py

@@ -6,16 +6,19 @@
 from sentry.testutils.silo import control_silo_test
 
 
+@control_silo_test
+def test_anonymous(client):
+    response = client.get(reverse("sentry-api-index"))
+    assert response.status_code == 200
+    assert response.data["version"] == "0"
+    assert not response.data["user"]
+    assert not response.data["auth"]
+
+
 @control_silo_test
 class ApiIndexTest(APITestCase):
     endpoint = "sentry-api-index"
 
-    def test_anonymous(self):
-        response = self.get_success_response()
-        assert response.data["version"] == "0"
-        assert not response.data["user"]
-        assert not response.data["auth"]
-
     def test_session_auth(self):
         self.login_as(user=self.user)
         response = self.get_success_response()

tests/sentry/auth/providers/test_saml2.py

@@ -1,13 +1,12 @@
 from __future__ import annotations
 
 from typing import Any
-from unittest import mock
+from unittest import TestCase, mock
 
 import pytest
 
 from sentry.auth.exceptions import IdentityNotValid
 from sentry.auth.providers.saml2.provider import Attributes, SAML2Provider
-from sentry.testutils.cases import TestCase
 from sentry.testutils.silo import control_silo_test
 
 dummy_provider_config = {

tests/sentry/backup/test_sanitize.py

@@ -1,6 +1,7 @@
 from collections.abc import Sequence
 from datetime import datetime, timedelta
 from typing import Any
+from unittest import TestCase
 from unittest.mock import Mock, patch
 
 import orjson
@@ -24,7 +25,6 @@
 from sentry.db.models.fields.jsonfield import JSONField
 from sentry.db.models.fields.slug import SentrySlugField
 from sentry.db.models.fields.uuid import UUIDField
-from sentry.testutils.cases import TestCase
 
 FAKE_EMAIL = "test@fake.com"
 FAKE_NAME = "Fake Name"

tests/sentry/cache/test_django.py

@@ -1,7 +1,7 @@
 import time
+from unittest import TestCase
 
 from sentry.cache.django import DjangoCache
-from sentry.testutils.cases import TestCase
 
 
 class DjangoCacheTest(TestCase):