fix tests

Author: lobsterkatie

tests/sentry/grouping/ingest/test_seer.py

@@ -342,7 +342,8 @@ def test_sends_expected_data_to_seer(self, mock_get_similarity_data: MagicMock)
                 "k": 1,
                 "referrer": "ingest",
                 "use_reranking": True,
-            }
+            },
+            {"hybrid_fingerprint": False},
         )
 
     def test_parent_group_found_simple(self) -> None:
@@ -376,7 +377,10 @@ def test_parent_group_found_simple(self) -> None:
                 existing_grouphash,
             )
 
-    def test_parent_group_found_hybrid_fingerprint_match(self) -> None:
+    @patch("sentry.grouping.ingest.seer.metrics.incr")
+    def test_parent_group_found_hybrid_fingerprint_match(
+        self, mock_metrics_incr: MagicMock
+    ) -> None:
         existing_event = save_new_event(
             {"message": "Dogs are great!", "fingerprint": ["{{ default }}", "maisey"]},
             self.project,
@@ -411,8 +415,16 @@ def test_parent_group_found_hybrid_fingerprint_match(self) -> None:
                 expected_metadata,
                 existing_grouphash,
             )
+            mock_metrics_incr.assert_called_with(
+                "grouping.similarity.hybrid_fingerprint_seer_result_check",
+                sample_rate=options.get("seer.similarity.metrics_sample_rate"),
+                tags={"platform": "python", "result": "fingerprint_match"},
+            )
 
-    def test_parent_group_found_hybrid_fingerprint_mismatch(self) -> None:
+    @patch("sentry.grouping.ingest.seer.metrics.incr")
+    def test_parent_group_found_hybrid_fingerprint_mismatch(
+        self, mock_metrics_incr: MagicMock
+    ) -> None:
         existing_event = save_new_event(
             {"message": "Dogs are great!", "fingerprint": ["{{ default }}", "maisey"]},
             self.project,
@@ -443,8 +455,16 @@ def test_parent_group_found_hybrid_fingerprint_mismatch(self) -> None:
                 expected_metadata,
                 None,
             )
+            mock_metrics_incr.assert_called_with(
+                "grouping.similarity.hybrid_fingerprint_seer_result_check",
+                sample_rate=options.get("seer.similarity.metrics_sample_rate"),
+                tags={"platform": "python", "result": "no_fingerprint_match"},
+            )
 
-    def test_parent_group_found_hybrid_fingerprint_on_new_event_only(self) -> None:
+    @patch("sentry.grouping.ingest.seer.metrics.incr")
+    def test_parent_group_found_hybrid_fingerprint_on_new_event_only(
+        self, mock_metrics_incr: MagicMock
+    ) -> None:
         existing_event = save_new_event(
             {"message": "Dogs are great!"},
             self.project,
@@ -475,8 +495,16 @@ def test_parent_group_found_hybrid_fingerprint_on_new_event_only(self) -> None:
                 expected_metadata,
                 None,
             )
+            mock_metrics_incr.assert_called_with(
+                "grouping.similarity.hybrid_fingerprint_seer_result_check",
+                sample_rate=options.get("seer.similarity.metrics_sample_rate"),
+                tags={"platform": "python", "result": "only_event_hybrid"},
+            )
 
-    def test_parent_group_found_hybrid_fingerprint_on_existing_event_only(self) -> None:
+    @patch("sentry.grouping.ingest.seer.metrics.incr")
+    def test_parent_group_found_hybrid_fingerprint_on_existing_event_only(
+        self, mock_metrics_incr: MagicMock
+    ) -> None:
         existing_event = save_new_event(
             {"message": "Dogs are great!", "fingerprint": ["{{ default }}", "maisey"]},
             self.project,
@@ -505,8 +533,16 @@ def test_parent_group_found_hybrid_fingerprint_on_existing_event_only(self) -> N
                 expected_metadata,
                 None,
             )
+            mock_metrics_incr.assert_called_with(
+                "grouping.similarity.hybrid_fingerprint_seer_result_check",
+                sample_rate=options.get("seer.similarity.metrics_sample_rate"),
+                tags={"platform": "python", "result": "only_parent_hybrid"},
+            )
 
-    def test_parent_group_found_hybrid_fingerprint_no_metadata(self) -> None:
+    @patch("sentry.grouping.ingest.seer.metrics.incr")
+    def test_parent_group_found_hybrid_fingerprint_no_metadata(
+        self, mock_metrics_incr: MagicMock
+    ) -> None:
         """
         Test that even when there's a match, no result will be returned if the matched hash has
         no metadata.
@@ -550,6 +586,11 @@ def test_parent_group_found_hybrid_fingerprint_no_metadata(self) -> None:
                 expected_metadata,
                 None,
             )
+            mock_metrics_incr.assert_called_with(
+                "grouping.similarity.hybrid_fingerprint_seer_result_check",
+                sample_rate=options.get("seer.similarity.metrics_sample_rate"),
+                tags={"platform": "python", "result": "no_parent_metadata"},
+            )
 
     def test_no_parent_group_found(self) -> None:
         new_event, new_variants, new_grouphash, _ = self.create_new_event()
@@ -621,7 +662,8 @@ def test_simple(self, mock_get_similarity_data: MagicMock) -> None:
                 "k": 1,
                 "referrer": "ingest",
                 "use_reranking": True,
-            }
+            },
+            {"hybrid_fingerprint": False},
         )
 
     @patch("sentry.grouping.ingest.seer.record_did_call_seer_metric")
@@ -742,7 +784,8 @@ def test_too_many_frames_bypassed_platform(self, mock_get_similarity_data: Magic
                 "k": 1,
                 "referrer": "ingest",
                 "use_reranking": True,
-            }
+            },
+            {"hybrid_fingerprint": False},
         )