Merge branch 'master' into ref/process-segments-eap-items

Author: untitaker

static/app/components/sidebar/index.tsx

@@ -227,6 +227,7 @@ function Sidebar() {
         to={`/organizations/${organization?.slug}/explore/logs/`}
         id="ourlogs"
         icon={<SubitemDot collapsed />}
+        isNew
       />
     </Feature>
   );

static/app/views/insights/mobile/screens/utils.ts

@@ -6,7 +6,7 @@ import type {MetricsProperty, SpanMetricsProperty} from 'sentry/views/insights/t
 import {VitalState} from 'sentry/views/performance/vitalDetail/utils';
 
 const formatMetricValue = (metric: MetricValue, field?: string | undefined): string => {
-  if (metric.value === undefined) {
+  if (metric.value === undefined || metric.value === null) {
     return '-';
   }
   if (typeof metric.value === 'number' && metric.type === 'duration' && metric.unit) {

static/app/views/nav/secondary/sections/explore/exploreSecondaryNav.tsx

@@ -1,5 +1,7 @@
 import Feature from 'sentry/components/acl/feature';
+import {FeatureBadge} from 'sentry/components/core/badge/featureBadge';
 import {t} from 'sentry/locale';
+import localStorage from 'sentry/utils/localStorage';
 import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 import {useGetSavedQueries} from 'sentry/views/explore/hooks/useGetSavedQueries';
@@ -22,6 +24,9 @@ export function ExploreSecondaryNav() {
     perPage: MAX_STARRED_QUERIES_DISPLAYED,
   });
 
+  const ourlogsSeenKey = `sidebar-new-seen:ourlogs`;
+  const showOurlogsNew = !localStorage.getItem(ourlogsSeenKey);
+
   return (
     <SecondaryNav>
       <SecondaryNav.Header>
@@ -39,7 +44,17 @@ export function ExploreSecondaryNav() {
             </SecondaryNav.Item>
           </Feature>
           <Feature features="ourlogs-enabled">
-            <SecondaryNav.Item to={`${baseUrl}/logs/`} analyticsItemName="explore_logs">
+            <SecondaryNav.Item
+              to={`${baseUrl}/logs/`}
+              analyticsItemName="explore_logs"
+              trailingItems={showOurlogsNew ? <FeatureBadge type="new" /> : null}
+              onMouseDown={() => {
+                localStorage.setItem(ourlogsSeenKey, 'true');
+              }}
+              onTouchStart={() => {
+                localStorage.setItem(ourlogsSeenKey, 'true');
+              }}
+            >
               {t('Logs')}
             </SecondaryNav.Item>
           </Feature>